- Issue created by @_shY
- Assigned to Oleksandr P.
- Merge request !6Issue #3417232: Fixed comments on the relevant places and also fixed coding standards where needed. → (Open) created by Oleksandr P.
- Issue was unassigned.
- Status changed to Needs review
5 months ago 3:09pm 27 January 2024 - 🇺🇦Ukraine Oleksandr P. Lutsk
Fixed comments on the relevant places and also fixed coding standards where needed. Created a new MR.
- Status changed to Needs work
5 months ago 3:26pm 27 January 2024 - 🇺🇦Ukraine _shY Lutsk
Still have some errors:
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$? ------ ------------------------------------------------------------------------------ Line fiu_ui/src/Form/SettingsForm.php ------ ------------------------------------------------------------------------------ 57 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ - Assigned to ankondrat4
- Issue was unassigned.
- Status changed to Needs review
5 months ago 4:00pm 27 January 2024 - First commit to issue fork.