Unable to add custom logo and/or icon

Created on 25 January 2024, 5 months ago
Updated 20 June 2024, 5 days ago

Problem/Motivation

The adaptation from version 4 to version 5 so that the theme would be compatible with Drupal 10 has an error.
Because the initialisation of the source path is wrong, many other paths are wrong too.

Steps to reproduce

Proposed resolution

The line 98 in the file adaptivetheme/at_core/forms/color/color_submit.php should have this line:
$paths['source'] = \Drupal::service('extension.list.theme')->getPath($theme) . '/'; and not
$paths['source'] = \Drupal::service('extension.list.theme')->getPath($theme);

Remaining tasks

The solution is in the bug description.
Review, merge and release.

User interface changes

API changes

Data model changes

🐛 Bug report
Status

RTBC

Version

7.0

Component

Theme Settings

Created by

🇧🇪Belgium EricVL

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @EricVL
  • First commit to issue fork.
  • Status changed to Needs review 4 months ago
  • 🇮🇳India dineshkumarbollu

    Hi @EricVL

    created MR!6, Check other parts of the code also no issues expect the adaptivetheme/at_core/forms/color/color_submit.php file, please review, Thanks

  • Status changed to RTBC 4 months ago
  • 🇧🇪Belgium EricVL

    I believe, this merge request is still not merged into the latest release(s) although it is a major problem.
    The original version was 5.2 when this isue was discovered. I changed the version to 7.
    Is it possible that a maintainer looks into this issue please.
    I"m using a local patch now to have the same result.
    Thank you.

    • 636af633 committed on 8.x-6.x
      Issue #3417049 by dineshkumarbollu, EricVL: Unable to add custom logo...
  • This will make into a new release today.

    • 670aeb0a committed on 7.0.x
      Issue #3417049 by dineshkumarbollu, EricVL: Unable to add custom logo...
  • 🇧🇪Belgium EricVL

    Thank you, Matt for the new 7.1 release.
    Just 1 question: why don"t we see the 7.x releases on the Home page of this theme?
    I do not have a problem with that because i"m using composer to get my packages. But if someone likes to check the latest version and download it there, he can't.
    Greetings
    Eric

    PS the 2 issues that you solved in this latest release can be closed AFAIK.

  • 🇧🇪Belgium EricVL

    Sorry Matt. Now I can see the reference to the 7.1 build.
    I was too quick to respond.

Production build 0.69.0 2024