- Issue created by @Anybody
- π©πͺGermany Anybody Porta Westfalica
@thomas.frobieter could you please finally check this?
thomas.frobieter β made their first commit to this issueβs fork.
https://git.drupalcode.org/issue/billwerk_subscriptions-3416871/-/blob/1...
There is no parent wrapper "billwerk-component-subscription", so all "billwerk-component-subscription__x" classes are wrong.
I cannot access the subscription page of the current project because of "GuzzleHttp\Exception\ClientException: Client error [...]", so I can't check where these elements go and what the correct names are.
- π©πͺGermany Anybody Porta Westfalica
There is no parent wrapper "billwerk-component-subscription", so all "billwerk-component-subscription__x" classes are wrong.
Are you preparing a MR to fix this or do you need help?
Retry with a new account please.
- Merge request !13Draft: Resolve #3416871 "Default classes structure" β (Closed) created by Anybody
- π©πͺGermany Anybody Porta Westfalica
There is no parent wrapper "billwerk-component-subscription", so all "billwerk-component-subscription__x" classes are wrong.
I fixed that, classes were copied from the other file and not replaced correctly.
- π©πͺGermany Anybody Porta Westfalica
@thomas.frobieter still things left to be done here?
There are still some TODOs in the twig files FYI.
Fixed classnames, I won't add any styling to the module, as it leads up to massive time consumption, while I don't see any benefits for us.
-
thomas.frobieter β
committed e5894f6a on 1.x authored by
Anybody β
Fix #3416871
-
thomas.frobieter β
committed e5894f6a on 1.x authored by
Anybody β
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 12:00pm 12 April 2024 - Assigned to thomas.frobieter
- Status changed to Active
about 1 year ago 12:01pm 12 April 2024 - π©πͺGermany Anybody Porta Westfalica
@thomas.frobieter can you then please remove all the TODOs from all the twig files?
-
thomas.frobieter β
committed 729c9c1a on 1.x
Issue #3416871 by Anybody, thomas.frobieter: Default classes, structure...
-
thomas.frobieter β
committed 729c9c1a on 1.x
- Status changed to Fixed
about 1 year ago 12:19pm 12 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.