Remove install container definitions of FileSystem and StreamWrapperManager

Testing what happens if we just remove file_system and stream_wrapper_manager entirely here.

Seems dead-as-dodo-code to me => RTBC (without the need for a followup...😈😇)

larowlan → credited sun → .

Did some git ancestry

The stream wrapper manager was added in a bad reroll by me → in #2028109: Convert hook_stream_wrappers() to tagged services. → which was pointed out by @sun in comment 152. Crediting sun here for that all these years later.

The file system entry was added in #2050759: Move drupal_chmod and other code in file.inc to a Drupal\Core\File\FileSystem class → around the same time (late 2014/early 2015)

Manually ran an install and verified this hunk is where we boot an actual container now, which contains the file system service.

// Note, InstallerKernel::createFromRequest() is not used because Settings is
  // already initialized.
  $kernel = new InstallerKernel($environment, $class_loader, FALSE);
  $kernel::bootEnvironment();
  $kernel->setSitePath($site_path);
  $kernel->boot();

$kernel->boot(); loads core.services.yml which loads the actual file system service.

So the subsequent use of the file system lower down is fine

/** @var \Drupal\Core\File\FileSystemInterface $file_system */
  $file_system = $container->get('file_system');
  $container->set('string_translator.file_translation', new FileTranslation($directory, $file_system));
  $container->get('string_translation')
    ->addTranslator($container->get('string_translator.file_translation'));

crediting myself for this archeology work

Committed to 11.x, thanks!

larowlan → closed merge request !6307

Hm … this would be a delightfully simple explanation for 🐛 Stream wrappers not registered when installing module's default config Active and potentially fixes that altogether 🧐

Automatically closed - issue fixed for 2 weeks with no activity.