Ajax dialogs won't display corretctly if they contain multiple HTML elements

finnsky → closed merge request !3

finnsky → changed the visibility of the branch 3416649-f to hidden.

finnsky → changed the visibility of the branch 3416649-f to active.

We have 1.x and 1.0.x it makes some misunderstandings ;)

Nvm. Pushed hotfix for ajax blocks. It works now. Later we need to review it more carefully.

We have 1.x and 1.0.x

Yes... super annoying @Anybody accidentally created 1.0.x, and I wanted to create a dev release on 1.x, but accidentally created one on 1.0.x, because we created dev releases simultaneously... unfortunately 1.0.x can not be removed...

MR looks interesting, are the other already tested dialog scenarios still working after these changes (see https://www.drupal.org/project/drupal/issues/2158943#comment-15405906 📌 Add a native dialog element to deprecate the jQuery UI dialog Needs work )?

Yes. Just tested it. All fine
https://gyazo.com/02a36d4bb44e1587bbc4fa2f9abc808b

Found more issues here like announcement dialog
https://gyazo.com/280557b6019d1ab6aff27f6ed9f65589

The current code doesn't seem to fix the creation of the drupal-modal wrapper in drupal.ajax.js, as the comment states?

Ok, I see the fix now. We are currently only getting the first element of "drupal-modal", but on some occasions, there are multiple elements in "drupal-modal". I am still against keeping the unnecessary div in. Instead we should create a "dialog-native_content" div and paste all the HTML elements in there.

Fixed!

Please review!

I also adjusted the order of the theme functions (header top, content mid, buttons bot).

Looks good to me. Thank you!

Cheers!

Automatically closed - issue fixed for 2 weeks with no activity.