- Issue created by @SocialNicheGuru
- ๐ฑ๐นLithuania mindaugasd
[warning] Undefined variable $extra_fields aiprompt_content.module:23
in aiprompt case, it is used here: https://git.drupalcode.org/project/aiprompt/-/blob/1.0.x/src/Traits/AIPr...
[warning] Undefined variable $extra_fields aichat.module:69
in aichat case, I don't find it being already used, but there is future intention to use it.How did you find the bug? Does it have impact in any way? It is certainly not "major" bug, I am downgrading to "minor".
- Assigned to abhishek_virasat
- Status changed to Needs review
11 months ago 5:11am 24 January 2024 - ๐ฎ๐ณIndia abhishek_virasat
@SocialNicheGuru, I have fixed the issue. please kindly review the mR
- ๐ฑ๐นLithuania mindaugasd
From the merge request now I see what @SocialNicheGuru meant.
I did not know that undefined variable can be an issue and not even understood the problem from the issue description, and after researching additionally a bit, now I agree it is an issue.
I also forgot that this issue was in the past already ๐ Undefined variable $extra_fields inย aiprompt_content_entity_extra_field_info() Needs review within my issue queues.On the other hand, @abhishek_gupta1, you produced a low quality merge request for the second time like in the issue I referenced above.
This line is too much info, because it is self evident that variable is being initialized.
// Initialize $extra_fields as an empty array.Please don't credit farm. Neither of your contributions will be recorded. You won't be so lucky as other credit farmers were already here: #3367843-3: Fix the issues reported by phpcs โ
For comparison - I have not recorded credit for myself after creating a module in the first place after spending hundreds of hours. Contributions should be for providing value, not for farming credit.
-
mindaugasd โ
committed 86b27c87 on 1.0.x
Issue #3416591: [warning] Undefined variable $extra_fields aichat....
-
mindaugasd โ
committed 86b27c87 on 1.0.x
- Status changed to Fixed
11 months ago 7:16am 24 January 2024 - ๐บ๐ธUnited States SocialNicheGuru
Please record credit for yourself. You did develop the module!
- ๐ฑ๐นLithuania mindaugasd
It is not possible to record credit for the module, only for issues (after each issue is completed I believe).
- ๐บ๐ธUnited States SocialNicheGuru
That was my roundabout way of just saying job well done.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฉ๐ฐDenmark ressa Copenhagen
Thank you @mindaugasd, I just want to say that I also really appreciate your big efforts in the AI-space in Drupal.