- Issue created by @shweta__sharma
Tanushree Gupta → made their first commit to this issue’s fork.
- Merge request !11banner-image: Correct the image resolution of banner. → (Open) created by Tanushree Gupta
- Status changed to Needs review
8 months ago 7:20am 28 March 2024 Corrected the image resolution so that the banner image will not look blur.
- Status changed to Needs work
6 months ago 10:15am 5 June 2024 Tanushree Gupta → changed the visibility of the branch picked_fresh-3416412-banner-image to hidden.
- Status changed to Needs review
6 months ago 7:18am 6 June 2024 Updated the code with the changes mentioned.
Here is the commit:
https://git.drupalcode.org/project/picked_fresh/-/merge_requests/11/diff...- Status changed to RTBC
6 months ago 8:12am 6 June 2024 @Tanushree Gupta, Now the changes look fine to me and all the comments have been addressed as I can see. But I noticed that here the CTA buttons are actually a part of the image and not actually a button. The title, the CTA buttons and the side thumbnail image all are part of the banner image, but it should not be like this, only side image should be considered as image and other should be considered as per their standard usage. Though its beyond the scope of this issue, hence moving it to RTBC++