- Issue created by @catch
- Status changed to Needs review
11 months ago 10:41pm 20 January 2024 - π¬π§United Kingdom catch
Before: https://git.drupalcode.org/project/drupal/-/jobs/668164
After: https://git.drupalcode.org/project/drupal/-/jobs/668355
Potentially a full minute off the job length once a couple of other slow tests that were hidden by this one were added to @group #slow.
- Status changed to RTBC
11 months ago 6:26am 21 January 2024 - π³π±Netherlands spokje
Very vice find, good sir!
Changes look OK to me,
UpdatePathTestBaseTest
will still run on its own, so no coverage loss. - Status changed to Needs review
11 months ago 10:37pm 24 January 2024 - π¬π§United Kingdom longwave UK
I'm not sure it's *entirely* pointless. I think
testDatabaseLoaded()
is worth keeping ensure that both the bare and filled dumps aren't corrupt in some way? Was also unsure abouttestUpdateHookN()
but it turns out the module lists are the same so that one does look like repeated work. - π¬π§United Kingdom catch
I've moved
testDatabaseLoaded()
to a protected method on the base class, and called it from both of these tests so we don't lose coverage. - Status changed to Needs work
11 months ago 8:16pm 28 January 2024 - Status changed to Needs review
11 months ago 2:32pm 29 January 2024 - Status changed to RTBC
11 months ago 3:02pm 29 January 2024 - π¬π§United Kingdom longwave UK
Backported to 10.2.x to keep things in sync.
Committed and pushed c5e634873a to 11.x and 660b30a0c3 to 10.2.x. Thanks!
-
longwave β
committed 660b30a0 on 10.2.x
Issue #3416074 by catch, longwave: UpdatePathTestBaseFilledTest is...
-
longwave β
committed 660b30a0 on 10.2.x
- Status changed to Fixed
11 months ago 5:17pm 3 February 2024 -
longwave β
committed c5e63487 on 11.x
Issue #3416074 by catch, longwave: UpdatePathTestBaseFilledTest is...
-
longwave β
committed c5e63487 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.