Experimental branch using dialogNative + dialogAdapter (former dialog.core.js) by @bnjmnm

Open on Drupal.org →

Created on 19 January 2024, over 1 year ago

Problem/Motivation

This issue is used for preserving a version of the module, where we try to incorperate the jquery adapter logic from "dialog.core.es6.js" by @bnjmnm to in conjunction with dialogNative.js.

This version uses a lot of deprecated jquery Methods, but this approach might be superior to the approach in the main module, if reworked correctly.

He basically overwrites jQuery's "$(element).dialog" call with his own implementation, using the native dialog HTML element.

Steps to reproduce

Proposed resolution

Discuss if this might be the more superior approach to this issue.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Postponed

Version

1.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!1Experimental branch using dialogNative + dialogAdapter (former dialog.core.js) by @bnjmnm
Open
🇩🇪Germany Grevil
updated over 1 year ago

Comments & Activities

Issue created by @Grevil
Comment over 1 year ago →
🇩🇪Germany Grevil
Comment over 1 year ago →
🇩🇪Germany Grevil
Alright, I need to do a cut here. I talked with @Anybody and the main module's approach might be actually the way to do it. Keeping this issue open still.
Comment over 1 year ago →
🇩🇪Germany Grevil
I could get it to the point, where no errors appeared, but I still generate the jquery dialog.
Merge request !1Draft: Issue #3415881: Experimental branch using dialogNative + dialogAdapter (former dialog.core.js) by @bnjmnm → (Open) created by Grevil
Status changed to Postponed over 1 year ago3:37pm 19 January 2024
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Let's postpone this for now as possible alternative, if we totally fail otherwise.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024