- Issue created by @Grevil
- Merge request !2Issue #3415831 by finnsky, Grevil: Implement an "x to close" dialog option → (Merged) created by finnsky
- 🇷🇸Serbia finnsky
Added theming functions for dialog content header and buttons. What will be useful for custom theme developers.
Added close button which triggers customEvent with bubble.Also added small code improvements.
1. Core version +11
2. Grouped dialog settings likeif (settings.width) { if (Number.isInteger(settings.width)) { dialogContainer.style.setProperty('width', `${settings.width}px`); } else { dialogContainer.style.setProperty('width', settings.width); } }
TO:
[ 'width', 'height', 'minWidth', 'maxWidth', 'minHeight', 'maxHeight' ].forEach(dimension => {
- Status changed to Needs review
over 1 year ago 12:31pm 23 January 2024 - Status changed to Needs work
over 1 year ago 4:11pm 26 January 2024 - Status changed to Needs review
over 1 year ago 8:14am 29 January 2024 - Status changed to Needs work
over 1 year ago 2:00pm 29 January 2024 - 🇩🇪Germany Grevil
Great stuff!! Thanks a lot @finnsky!
I guess we still should add some styling to the close button, currently it is quite lackluster. Is there any drupal native "x" button, where we could clone the styling from?
Furthermore, it might make sense to have an optional parameter for the close button in "Drupal.theme.dialogHeader". I am not a theming expert, but this would only make sense to me.Otherwise, LGTM!
- 🇩🇪Germany Grevil
Let's move the styling part to 📌 The styling of the dialog element needs adjusting. Active .
- 🇩🇪Germany Grevil
@finnsky we could also create a follow-up ticket for only styling the close button, feel free to decide yourself here.
- 🇷🇸Serbia finnsky
Thank you for review.
it might make sense to have an optional parameter for the close button in "Drupal.theme.dialogHeader".
in fact `Drupal.theme.dialogHeader"` it is the option for theme developer for overriding header.
On my side i would better to move with webcomponent and slots.
- Status changed to RTBC
over 1 year ago 2:12pm 29 January 2024 - 🇩🇪Germany Grevil
Alright! I am not too knowledgeable on Drupal theme development, just was something I thought would make sense hear.
RTBC then!
- Status changed to Fixed
over 1 year ago 2:13pm 29 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.