- Issue created by @akhil_01
Hi @Ankit_Kumar @whitedevil
I have created MR For the Adding Hook help in this module
please review it once
Thank you
- Assigned to apatel0325
- Issue was unassigned.
- Status changed to Needs review
9 months ago 6:36am 18 March 2024 - Status changed to RTBC
7 months ago 1:02pm 31 May 2024 - šµšPhilippines cleavinjosh
Hi @akhil_01, apatel0325,
I applied MR!1, it was applied smoothly and added the hook help.
Please see my attached files.
As per the phpcs mentioned on comment #4, I still encounter some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
ā link_field_filter git:(main) ā curl https://git.drupalcode.org/project/link_field_filter/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1633 0 1633 0 0 782 0 --:--:-- 0:00:02 --:--:-- 782 patching file link_field_entity_filter.module ā link_field_filter git:(main) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml link_field_filter FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/link_field_filter/link_field_entity_filter.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically 6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ Time: 140ms; Memory: 10MB
I will now move the status to Reviewed & tested by the community since the issue is about the hook help.
Thank you.
-
whitedevil ā
committed fc6ae0f7 on 1.0.x authored by
akhil_01 ā
Issue #3415804: Hook help missing
-
whitedevil ā
committed fc6ae0f7 on 1.0.x authored by
akhil_01 ā
- š®š³India ankit_k
Thanks for your contribution. It will be fixed in the next release