- Issue created by @mxr576
- last update
8 months ago 536 pass - Status changed to Needs review
8 months ago 3:55pm 18 January 2024 - Status changed to Closed: won't fix
5 months ago 10:30am 5 April 2024 - πΊπΈUnited States jrockowitz Brooklyn, NY
I am very hesitant to support or implement any new APIs. I think this type of API needs to be provided by a contributed module
- Status changed to Active
about 2 months ago 11:11am 23 July 2024 - ππΊHungary mxr576 Hungary
I have seen your answer Jacob, my first and most important question: Do you have a practical suggestion for how a contrib/custom code could add this functionality? Because based on my proposed change it would be only possible by overriding and subclassing
\Drupal\webform\WebformSubmissionForm
which I would avoid due to multiple potential maintenance traps in the road ahead...I am very hesitant to support or implement any new APIs.
The other question is why are you...? This project is still active and growing, DX should become better as well, not just the site builder experience. Actually, with this new API we can potentially serve multiple personas.
- ππΊHungary mxr576 Hungary
Because based on my proposed change it would be only possible by overriding and subclassing \Drupal\webform\WebformSubmissionForm which I would avoid due to multiple potential maintenance traps in the road ahead...
I also checked what calls
\Drupal\webform\WebformSubmissionForm::prepopulateData()
and it is\Drupal\webform\WebformSubmissionForm::buildForm()
so we are not closer with that either... unless we try to add this feature via a form alter which is meh... - πΊπΈUnited States ChristophWeber
Just stumbling over this...
I think such an API would be powerful and belongs into webform itself, not a separate module. @jrockowitz I fully understand your hesitance to add new APIs, that makes total sense, but this one would add quite a few new opportunities to webform that justify the exception.