- Issue created by @mstrelan
- π¦πΊAustralia mstrelan
We already have an equivalent Kernel test for this. See
\Drupal\KernelTests\Core\Config\SchemaConfigListenerTest
. It seems this is supposed to remain a Functional test. But we should update this comment for clarity:- * Tests the functionality of ConfigSchemaChecker in KernelTestBase tests. + * Tests the functionality of ConfigSchemaChecker in BrowserTestBase tests.
- π³π±Netherlands spokje
The comment change is a win no matter what.
However, I have _no_ clue how this and its KernelTest sibling are testing the config schemas, since that logic was changed in #2625212: Add ConfigSchemaChecker to development.services.yml β .
FYI: I often have _no_ clue and need to be explained what's going on.I'll ping @alexpott and/or other core committers to get that explanation and maybe it's worth adding that to both the tests so this is clear once and for all?
- π³π±Netherlands spokje
Can I join the clueless club?
Well, we as a club have no clue on what rules apply to becoming a member, so hop on in! ;)
- Status changed to RTBC
12 months ago 8:28am 17 January 2024 - π¬π§United Kingdom alexpott πͺπΊπ
The change in the MR is correct.
And yes this test is testing something. Add the following code to the class and you will see it fail.
protected $strictConfigSchema = FALSE;
The test is in \Drupal\Tests\Traits\Core\Config\SchemaConfigListenerTestTrait so that the Kernel and Functional tests can share.
- Status changed to Fixed
12 months ago 2:21pm 19 January 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.