Contrib.social

Missing template suggestions after upgrading to 3.17

Open on Drupal.org →
Created on 17 January 2024, 11 months ago
Updated 31 January 2024, 11 months ago

Problem/Motivation

After upgrading to 3.17, Twig template overrides don't seem to take effect.

Regression in the upgrade from 3.16 -> 3.17.

Steps to reproduce

I managed to bisect the issue to the changes introduced by 🐛 Template suggestions does not work Active .

Lets compare the suggestion markup provided by Twig debug:

Before

With 3.16, or commit #8a4f075 

FILE NAME SUGGESTIONS:
   * field--default--paragraph--field-image-slider-item--image-slider---custom.html.twig
   * field--default--paragraph--field-image-slider-item--image-slider.html.twig
   * field--default--paragraph--image-slider---custom.html.twig
   * field--default--paragraph--image-slider.html.twig
   x field--default--paragraph--field-image-slider-item.html.twig
   * field--default--field-image-slider-item--image-slider---custom.html.twig
   * field--default--field-image-slider-item--image-slider.html.twig
   * field--default--image-slider---custom.html.twig
   * field--default--image-slider.html.twig
   * field--default--field-image-slider-item.html.twig
   * field--default.html.twig
   * field--theme-ds-field-default.html.twig
   * field--paragraph--field-image-slider-item--image-slider.html.twig
   * field--paragraph--field-image-slider-item.html.twig
   * field--paragraph--image-slider.html.twig
   * field--field-image-slider-item.html.twig
   * field--entity-reference-revisions.html.twig
   * field.html.twig

After

With 3.17, or #833693c:

 FILE NAME SUGGESTIONS:
   * field--paragraph--field-image-slider-item--image-slider.html.twig
   * field--paragraph--field-image-slider-item.html.twig
   * field--paragraph--image-slider.html.twig
   * field--field-image-slider-item.html.twig
   * field--entity-reference-revisions.html.twig
   x field.html.twig

As you can see, all of the default prefix templates, among others, are not present.

Things ive tried:

Bonus configuration

3.16

_core:
  default_config_hash: xfB0qOeoAomOThclNNokdKTrVwXLcXz13SU3-4a5-FY
disabled: false
field_template: false
ft-default: default
ft-show-colon: false
classes:
  region: {  }
  field: {  }
use_field_names: true

After 3.17 upgrade

_core:
  default_config_hash: xfB0qOeoAomOThclNNokdKTrVwXLcXz13SU3-4a5-FY
disabled: false
field_template: false
classes:
  region: {  }
  field: {  }
use_field_names: true
ft_bc: true
exclude_layout_builder_blocks_on_block_field: false
ft_expert_prefix_suffix_textarea: false
ft_default: default
ft_show_colon: false
ft_layout_builder: null
exclude_ds_layout_layout_builder: false
layout_icon_image_bc: true
ft_default_bc: true
layout_suggestion_bc: true

Proposed resolution

Rework or revert.

Since its been only a few days since the release, I'd suggest a make or break decision to revert should happen soon.

Remaining tasks

tbd

User interface changes

nil

API changes

nil

Data model changes

configuration!?

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024