Creating blocks that depend on content via the config installer often generates a warning

Should add a test that proves the warning is removed.

Added details to the issue summary about the changes

AFAICT this is related to Recipes, and blocks the "default content" functionality there?

Fix \Drupal\Tests\ckeditor5\Kernel\SmartDefaultSettingsTest to not abuse the setSyncing() behaviour to get around the fact that the ckeditor plugin no longer exists in Drupal 10. See #3270734: Update Editor + CKEditor 5 module to not use CKEditor 4 in tests → for where this work-around was added.

The solution here is much better than my ::setSyncing() hack from #3270734: Update Editor + CKEditor 5 module to not use CKEditor 4 in tests → ! 👏🙈

  public function set($property_name, $value) {
-    if ($this instanceof EntityWithPluginCollectionInterface) {
+    if ($this instanceof EntityWithPluginCollectionInterface && !$this->isSyncing()) {

This is the crucial change. Shouldn't this also lead to improved performance, because it's no longer trying to instantiate plugins?

Test coverage looks sound. Only found a nit. Can't RTBC because of the one missing test, so marking NW, because once that test exists, I'll be comfortable RTBC'ing :)

Addressed @Wim Leers's feedback.

Still needs that one test AFAICT?

Oh that test exists already - it's added in core/tests/Drupal/KernelTests/Core/Config/ConfigImporterMissingContentTest.php

Ahhh, I thought you meant something else needed to be tested, I wasn't quite sure what 😄

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do. I read the MR and do not have any suggestions.

Leaving at RTBC;

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.