- Issue created by @alexpott
- Merge request !6207Stop doing unnecessary work when importing config entities β (Open) created by alexpott
- Status changed to Needs work
8 months ago 12:12am 17 January 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Should add a test that proves the warning is removed.
Added details to the issue summary about the changes
- Status changed to Needs review
8 months ago 10:55am 17 January 2024 - Status changed to Needs work
8 months ago 10:07am 19 January 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
AFAICT this is related to Recipes, and blocks the "default content" functionality there?
Fix \Drupal\Tests\ckeditor5\Kernel\SmartDefaultSettingsTest to not abuse the setSyncing() behaviour to get around the fact that the ckeditor plugin no longer exists in Drupal 10. See #3270734: Update Editor + CKEditor 5 module to not use CKEditor 4 in tests β for where this work-around was added.
The solution here is much better than my
::setSyncing()
hack from #3270734: Update Editor + CKEditor 5 module to not use CKEditor 4 in tests β ! ππpublic function set($property_name, $value) { - if ($this instanceof EntityWithPluginCollectionInterface) { + if ($this instanceof EntityWithPluginCollectionInterface && !$this->isSyncing()) {
This is the crucial change. Shouldn't this also lead to improved performance, because it's no longer trying to instantiate plugins?
Test coverage looks sound. Only found a nit. Can't RTBC because of the one missing test, so marking NW, because once that test exists, I'll be comfortable RTBC'ing :)
- Status changed to Needs review
8 months ago 10:13am 19 January 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Addressed @Wim Leers's feedback.
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Still needs that one test AFAICT?
- π¬π§United Kingdom alexpott πͺπΊπ
Oh that test exists already - it's added in core/tests/Drupal/KernelTests/Core/Config/ConfigImporterMissingContentTest.php
- Status changed to RTBC
8 months ago 12:42pm 19 January 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Ahhh, I thought you meant something else needed to be tested, I wasn't quite sure what π
- π³πΏNew Zealand quietone New Zealand
I'm triaging RTBC issues β . I read the IS and the comments. I didn't find any unanswered questions or other work to do. I read the MR and do not have any suggestions.
Leaving at RTBC;
- Status changed to Fixed
6 months ago 11:20am 1 March 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.