Convert HtmlToTextTest into a Unit test

Couldn't this be a unit test? Think we just need to ensure the global $base_url and $base_path variables are set.

Thanks @kim.pepper for being lenient, I know technically you're absolutely right and the type hinting is out of scope.
But I feel BC and the (correct) tight scoping is slowing drupal down sometimes and hope we can be a bit more "liberal" sometimes with tests only.

@mstrelan: Very nice Sir!
Can't RTBC since I worked on it, but looks good to go to me.

Unit test looks even better!

fwiw given it's only test changes, I think it's OK to sneak some cleanup in at the same time, given the code changes are pretty minimal. If it was runtime code, more than one test at a time (which I don't think we should do for these because most have one or two or more changes beyond a rename) or made it harder to review, I would probably push back though.

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

fwiw given it's only test changes, I think it's OK to sneak some cleanup in at the same time, given the code changes are pretty minimal

Thanks @catch, I was hoping this would be the case.

more than one test at a time (which I don't think we should do for these because most have one or two or more changes beyond a rename) or made it harder to review,

No worries, I'll do one at a time, we all know I'm just in it for the core credits... ;)

Spokje → closed merge request !6191

Automatically closed - issue fixed for 2 weeks with no activity.