- Issue created by @dydave
- Merge request !3Issue #3414889: Fixed WSOD TypeError when 'User Agent' is NULL by providing an... → (Merged) created by dydave
- Status changed to Needs review
10 months ago 3:38am 16 January 2024 - 🇫🇷France dydave
Added above at #3 Testing instructions, documented in the merge request (!MR3).
The module could certainly use some tests.
Thanks in advance for your feedback and reviews !
- 🇭🇷Croatia valic Osijek
Should we fallback to "Unknown" instead of empty string better?
- 🇫🇷France dydave
Hi Valentino (@valic),
Thank you very much for your prompt and clear follow-up on this ticket, it's greatly appreciated.
Just a quick reply to let you know the changes you suggested above at #5:
fallback to "Unknown" instead of empty string
have been made to the corresponding merge request which is now ready to be reviewed again, whenever you have some time.
Feel free to let us know if you have more comments, questions, suggestions or concerns on any of the changes in !MR3, this ticket or the project in general we would be glad to help.
Thanks again very much for your help reviewing these changes and for suggesting a much better solution. - Status changed to Fixed
10 months ago 10:04am 30 January 2024 - 🇫🇷France dydave
Thanks a lot Valentino (@valic) for the speedy and positive reply, it's greatly appreciated.
It's the second ticket you've approved and each time you've been super reactive : You're really a very active maintainer ! :)
Feel free to reach out at any point if you need any help with the modules you maintain or maybe tickets for projects I maintain, I would certainly be very happy to reply as soon as possible.
Thanks again very much for your contributions, help and great reactivity ! Automatically closed - issue fixed for 2 weeks with no activity.