JS Problem with Gin theme for checkbox on SlickUI

Created on 13 January 2024, 5 months ago
Updated 7 April 2024, 3 months ago

Problem/Motivation

The checkbox on the UI of Slick module is broken.

Steps to reproduce

Drupal v.10.1.6, Gin 8.x-3.0-rc8 and Slick 2.10
Go in SlickUi to see the checkbox button.

Proposed resolution

Use the default Drupal core coding standards it will automatically work.

💬 Support request
Status

Closed: duplicate

Version

2.10

Component

Documentation

Created by

🇮🇹Italy Idas Torino

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Idas
  • Status changed to Postponed 5 months ago
  • 🇮🇩Indonesia gausarts

    Thank you.

    It is Gin's bug, not this module's.

    Wrong room. Your title says "problem with Gin", but you still posted it here :)

    Quick solutions:

    1. Press the label, not the checkbox.
    2. Switch to core themes to prove it is Gin.

    Read more below if you want to know why, update your form API and improve your debug.

    > Use the default Drupal core coding standards it will automatically work.
    A typical unfortunate misidentification found anywhere else:
    💬 Something is preventing the click on the checkbox-toggle elements Fixed
    💬 Unable to check vanilla splide in views Fixed
    #2875173: Slick slideshow doesn't appear inside nodes, incompatible with Zircon →

    And many more.

    This should help you understand which the real standards are in this particular context, and hopefully improve your own future debug capabilities:

    • You must know how to distinguish core from non-core contribs.
    • Always use core, not contrib, themes as the only working valid standard to judge against and identify theme-related bugs correctly. Unlike contribs, core has more knowledgeable and strong contributors and reviewers. And we should use core as the guide or standards, not contribs. With contribs, or even non-dependency core, we can play nice instead only if we really need to. Supporting thousand contribs are out of question.

    The same principle applies to any projects, as well. It is generally applicable to any theme-related issues.

    How? Switch your themes to core ones at Admin > Appearance, and see it for yourself.

    The actual/ contextual bug:
    The contrib Gin does not know or most likely touch how to handle the placement of label/ title before its fancy checkbox, just yet. An obvious miss. Drupal provides form API with #title_display and its values can be "before", "after", etc.

    We used to have that fancy checkbox, and knew how to handle #title_display values very well, nothing new, so anyone with fair CSS knowledge should know about such CSS thingies just as easily.

    Hence placing label before and after checkbox are equally valid:
    https://www.drupal.org/docs/drupal-apis/form-api/form-render-elements#s-... →

    They are "the default Drupal core coding standards", and core themes, not necessarily contrib themes, "will automatically work" fine with both.

    Its default value doesn't nullify the fact that it has other possible values.

    This label placement is the very basic core form API standard that you don't actually understand, and Gin missed, and you blame this module for your own lack of understanding about the form API standards.

    No worries, though, aside from valid useful Bug reports, this module had also received wrong blames, wrong negativity, even insults, a few times, so yours is perfectly understandable, no biggies. Everyone, everything, learn something on their own phases. Even a language, like PHP, does learn. What matters is we are improving by learning our or others' mistakes. So hopefully nobody should post no useless misidentification like this no more.

    Please report it to Gin for the fix, instead. And leave this issue alone to avoid dups.

    Note:
    Intentionally postponed since this was reported here and anywhere else as dups. We don't want more dups.

    Do not change it back to Bug, like they did ignorantly at another issue, just because it was left open. An open issue is simply to avoid more unnecessary dups, not always a Bug.

    The OP issue had been actually documented very well for years, but some people simply hardly read, impolitely aka RTFM:
    https://git.drupalcode.org/project/slick/-/blob/8.x-2.10/docs/CONTRIBUTI...

    Next time, always post a Support request, if unsure, as documented above. A bug is bug, we'll mark it so even without you asking or saying so. Or post anything else that add a value to project issues. We welcome any properly categorized and valid post, even minor, except for repeatedly annoying bug dups and wrong negativity posts. Negative posts are genuinely welcome, but without data, docs or detailed info put on the table, or being tossed around off-handedly, they are mere useless gossips we never welcome, truly from the bikini bottom of our hearts.

    This is named project issues in an advanced civilization called Drupal, not project gossips. Keep it in mind at any projects. Learn more about project issues for your own highest good:
    https://www.drupal.org/node/3156242 →

  • Status changed to Closed: duplicate 3 months ago
  • 🇮🇩Indonesia gausarts

    3.x is out.

    Any contribution should refer to the provided docs as outlined at project home:
    https://git.drupalcode.org/project/slick/-/blob/3.0.x/docs/CONTRIBUTION....

Production build 0.69.0 2024