- Issue created by @scottop
- Status changed to Needs review
12 months ago 12:36pm 13 January 2024 - Open on Drupal.org βCore: 10.2.x + Environment: PHP 8.2 & MySQL 8last update
12 months ago Waiting for branch to pass - πΊπΈUnited States DamienMcKenna NH, USA
Looking over it, yeah we need some improvements there.
I took a look.
I think the module needs to be updated to use the new 2.0 branch of getID3, which is PSR4 compliant.
Please test this out, and check the included README.md file.
- πΊπΈUnited States scottop
Thank you. Yes, this patch fixed it.
I also had to remove the module and reinstall, because the patch wasn't working (the views_rss_media_getid3 was in the wrong place). Don't know how that happened, but probably my fault and not yours.
- πΊπΈUnited States scottop
OK, I spoke too soon. The module installed, but I do not see any new types of information I can add in the Views Fields. Searching for "audio" only gives me the field "Audio file" in the category "media" which I had before I installed this module.
There is no field like "id3" of "playtime" or "length" or "encoding". - πΊπΈUnited States DamienMcKenna NH, USA
When this module is installed it doesn't give you a new field, it gives a new option in the display settings.
- πΊπΈUnited States scottop
Damien, thank you for hanging in there. I don't know if I am still making a stupid mistake or if something is still not working. I have two questions:
First, I don't know what you mean by "a new option in the display settings". It seems most likely that you meant a new option in the Field Formatting options inside of Views, but there is none that I can find. Perhaps I don't have the right field selected for formatting, but here are the formatting options for the field that represents the actual audio file attached to the content:
I can select "URL to File", or "RSS Enclosure" and a few other things, but not "File length" or "Duration". - πΊπΈUnited States DamienMcKenna NH, USA
Ah.
I added some screenshots to the documentation that shows what part I'm talking about:
https://www.drupal.org/docs/contributed-modules/advanced-views-rss-feed/... β
Click the "Settings" link on the "Show" section, that's where you control the output of each item.
- πΊπΈUnited States DamienMcKenna NH, USA
This needs to be in the next release.
- First commit to issue fork.
- Status changed to RTBC
6 months ago 6:57am 19 July 2024 - ivnish Kazakhstan
I convert Damien's patch to MR and test it. Works as expected
-
DamienMcKenna β
committed 2a87a48c on 8.x-2.x
Issue #3414467 by ivnish, DamienMcKenna, scottop: Use getID3 v2...
-
DamienMcKenna β
committed 2a87a48c on 8.x-2.x
- Status changed to Fixed
6 months ago 10:42am 19 July 2024 - πΊπΈUnited States DamienMcKenna NH, USA
Committed, with a minor change to the README.md file and I updated composer.json to use v2. Thank you all.
- ivnish Kazakhstan
Hi Damien!
This line https://git.drupalcode.org/project/views_rss/-/commit/2a87a48c50b4aa8be3... has phpcs issue. I fixed it, but you changed this line and commited. What do we need to do? Fixed again or use phpcs:ignore?
-
DamienMcKenna β
committed dfce712a on 8.x-2.x
Issue #3414467 by ivnish: Follow-up to correct phpcs issues.
-
DamienMcKenna β
committed dfce712a on 8.x-2.x
- πΊπΈUnited States DamienMcKenna NH, USA
I fixed the issues and committed the changes directly. Thanks for spotting that.
-
DamienMcKenna β
committed 4c1d0ae3 on 8.x-2.x
Issue #3414467 by ivnish: Follow-up to correct phpcs issues.
-
DamienMcKenna β
committed 4c1d0ae3 on 8.x-2.x
Automatically closed - issue fixed for 2 weeks with no activity.