Issues reported by phpcs

Created on 11 January 2024, 5 months ago
Updated 5 March 2024, 3 months ago

Problem/Motivation

Steps to reproduce

$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source
FILE: ...les/custom/message_notify/tests/src/Kernel/MessageNotifyTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 152 | ERROR | Description for the @return value is missing
     |       | (Drupal.Commenting.FunctionComment.MissingReturnComment)
----------------------------------------------------------------------
FILE: ...fy/web/modules/custom/message_notify/src/Plugin/Notifier/Sms.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
 19 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
 21 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
 22 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
 23 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
 27 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
 28 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
 31 | WARNING | Code after the THROW statement on line 18 cannot be
    |         | executed
    |         | (Squiz.PHP.NonExecutableCode.Unreachable)
----------------------------------------------------------------------
FILE: ...ustom/message_notify/src/Plugin/Notifier/MessageNotifierBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 126 | ERROR | The array declaration extends to column 173 (the limit
     |       | is 120). The array content should be split up over
     |       | multiple lines
     |       | (Drupal.Arrays.Array.LongLineDeclaration)
----------------------------------------------------------------------
FILE: .../web/modules/custom/message_notify/src/Plugin/Notifier/Email.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  25 | WARNING | [ ] The class short comment should describe what the
     |         |     class does and not simply repeat the class
     |         |     name (Drupal.Commenting.ClassComment.Short)
 124 | ERROR   | [x] Use null coalesce operator instead of ternary
     |         |     operator.
     |         |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 178ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE                                                  ERRORS  WARNINGS
----------------------------------------------------------------------
...stom/message_notify/src/Plugin/Notifier/Email.php  1       1
...otify/src/Plugin/Notifier/MessageNotifierBase.php  1       0
...custom/message_notify/src/Plugin/Notifier/Sms.php  0       7
...age_notify/tests/src/Kernel/MessageNotifyTest.php  1       0
----------------------------------------------------------------------
A TOTAL OF 3 ERRORS AND 8 WARNINGS WERE FOUND IN 15 FILES
----------------------------------------------------------------------
PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
    SOURCE                                                       COUNT
----------------------------------------------------------------------
[ ] Squiz.PHP.NonExecutableCode.Unreachable                      7
[ ] Drupal.Arrays.Array.LongLineDeclaration                      1
[ ] Drupal.Commenting.ClassComment.Short                         1
[ ] Drupal.Commenting.FunctionComment.MissingReturnComment       1
[x] SlevomatCodingStandard.ControlStructures.RequireNullCoalesc  1
----------------------------------------------------------------------
A TOTAL OF 11 SNIFF VIOLATIONS WERE FOUND IN 5 SOURCES
----------------------------------------------------------------------

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States bluegeek9

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024