- Issue created by @bluegeek9
- last update
6 months ago 38 pass - last update
6 months ago 38 pass - Status changed to Needs review
6 months ago 11:55pm 10 January 2024 - Status changed to Needs work
5 months ago 4:33am 15 January 2024 - 🇵🇭Philippines paraderojether
Hi bluegeek9,
I reviewed MR! 23, applied against Message 8.x-1.x-dev with Drupal core version 10.1.7, and there are still remaining issues reported by phpcs shown below:
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig, message FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/message.module ---------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------- 198 | WARNING | Unused variable $message. ---------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Functional/MessageEntityDelete.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------- 172 | WARNING | Unused variable $delete_queue. 174 | WARNING | Unused variable $check_delete_queue. ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Functional/MenuTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Functional/MessageTemplateUiTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Kernel/Plugin/MessagePurge/QuotaTest.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 69 | WARNING | Unused variable $i. ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/README.md ----------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------- 21 | WARNING | Line exceeds 80 characters; contains 85 characters 65 | WARNING | Line exceeds 80 characters; contains 82 characters 90 | WARNING | Line exceeds 80 characters; contains 84 characters ----------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/modules/message_example/message_example.tokens.inc ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 65 | WARNING | Unused variable $token_service. 70 | WARNING | Unused variable $langcode. 73 | WARNING | Unused variable $langcode. 75 | WARNING | Unused variable $sanitize. ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/FormElement/MessageTemplateMultipleTextField.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 67 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Form/MessageTemplateForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 135 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Form/MessageSettingsForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 145 | WARNING | Unused variable $entity_id. ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Form/MessageTemplateDeleteConfirm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 18 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 25 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Entity/MessageTemplate.php -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 353 | WARNING | Unused variable $id. -------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Entity/Message.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 408 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Plugin/migrate/process/MessageProcessArguments.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 24 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/MessageTemplateListBuilder.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- Time: 1.29 secs; Memory: 12MBKindly check and advise, please.
Thank you. - last update
5 months ago 38 pass - Status changed to Fixed
5 months ago 1:59pm 30 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.