- Issue created by @pdureau
- 🇩🇪Germany Christian.wiedemann
I checked that yesterday. It can be done via rector. I prepared the attributes classes and the rector config yesterday.
- Assigned to Christian.wiedemann
- Merge request !136Resolve #3413609 "2.0.0 beta1 convert doctrine" → (Merged) created by Christian.wiedemann
- 🇩🇪Germany Christian.wiedemann
Was a lot more than I think, but now is everything clean. (I hope)
- Status changed to Needs review
5 months ago 4:31pm 7 July 2024 - 🇩🇪Germany Christian.wiedemann
Please merge this first. I changed a lot of code. (I also updated the t( to $this->t())
- 🇫🇷France just_like_good_vibes PARIS
hello, thanks Christian, i will review the MR and give my feedback before tomorrow :)
- 🇫🇷France just_like_good_vibes PARIS
- in modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewGroupTitleSource.php
there is a type between label and description. one is using "view", and the other is using "views", let's correct that :)- in src/Attribute/Source.php
i would have set description has being nullable as in other Attribute classes.- in src/Plugin/UiPatterns/DerivableContext/EntityFieldDerivableContext.php
Beware, the ID has been changed from "field" to "attributes". i guess this may be a copy paste error. please correct :)- in src/Plugin/UiPatterns/PropType/UnknownPropType.php
default_source null has disappeared.- in src/Plugin/UiPatterns/Source/CheckboxesWidget.php
why the attribute is on one line compared to the other ones?- in src/Plugin/UiPatterns/Source/MenuSource.php
maybe we should add a proper description- in src/Plugin/UiPatterns/Source/TokenSource.php
the context_definitions entity key has been changed, i guess it was by intention and seems to go in the right direction. but at least the code of the source should be patched according to this change.one those little things would be corrected, i will give it a last test and let's merge :)
- 🇩🇪Germany Christian.wiedemann
@just_like_good_vibes thanks! I fixed your remarks.
- Assigned to just_like_good_vibes
- 🇫🇷France just_like_good_vibes PARIS
hello Christian,
i just pushed a first quick bugfix direct in your MR.
i continue to test :) -
just_like_good_vibes →
committed 6a5442ee on 2.0.x authored by
Christian.wiedemann →
Issue #3413609 by Christian.wiedemann: [2.0.0-beta1] Convert doctrine...
-
just_like_good_vibes →
committed 6a5442ee on 2.0.x authored by
Christian.wiedemann →
- Status changed to Fixed
5 months ago 8:48am 11 July 2024 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.