When creating a new user in Drupal, an error occurs in the UserMailUniqueValidator class.

In this code modification, I enhanced the UserMailUniqueValidator class in the UserMailUniqueValidator.php file. The changes involve refactoring the constructor to leverage property promotion, which is a feature introduced in PHP 8.0. This helps simplify the code by declaring and initializing class properties directly within the constructor parameters.

Here's a breakdown of the changes:
Property Promotion in Constructor:

I replaced the individual property declarations and assignments in the constructor with property promotion.
Introduced property promotion for the AuthmapInterface, OpenidConnectRealmManagerInterface, EntityFieldManagerInterface, and EntityTypeManagerInterface properties.

Constructor Parameter Removal:
Removed the unnecessary parameters from the constructor, as property promotion takes care of both declaration and initialization.

Dependency Injection Enhancement:
Updated the create method to include the new dependencies (EntityFieldManagerInterface and EntityTypeManagerInterface) when instantiating the class.

1. +++ b/src/Plugin/Validation/Constraint/UserMailUniqueValidator.php
   @@ -36,9 +24,7 @@ class UserMailUniqueValidator extends UniqueFieldValueValidator implements Conta
   +  public function __construct(protected AuthmapInterface $authmap, protected OpenidConnectRealmManagerInterface $realm_manager,protected EntityFieldManagerInterface $entityFieldManager, protected EntityTypeManagerInterface $entityTypeManager) {
   

   Code style: space after $realm_manager,
   Code style: rename $realm_manager to $realmManager
   Drupal uses snake_case for method arguments, but camelCase for properties; I believe the fact you're defining a property here has precedence over the fact that it's a constructor argument.

2. +++ b/src/Plugin/Validation/Constraint/UserMailUniqueValidator.php
   @@ -68,7 +57,7 @@ class UserMailUniqueValidator extends UniqueFieldValueValidator implements Conta
   +        if ($this->realm_manager->hasDefinition($plugin_id)) {
   

   Revert this change based on previous remark.

Thanks for your merge request!

I'm not a big fan constructor property promotion since it causes mixed casing for class properties, so please change that as well.

I have fixed the reported issues and added a patch file please review
Thanks

Patch committed, thanks for the effort!

Automatically closed - issue fixed for 2 weeks with no activity.