H5P Editing broken after update to h5p-editor 1.25

Created on 5 January 2024, 12 months ago
Updated 9 February 2024, 11 months ago

Problem/Motivation

I am currently using the DEV version of h5p (2.0.x-dev@dev) because I understand from the community that it is required right now in order for it to work with Drupal 10.

With a site recent composer update, I noted that the h5p/h5p-editor component got update to v 1.25.

Since then, I am unable to edit or create H5P at all since the module cannot locate the libraries...

Digging deeper, I note...

Error: Call to undefined method H5PCore::libraryToFolderName() in H5peditor->mergeLocalLibsIntoCachedLibs() (line 628 of <site>\vendor\h5p\h5p-editor\h5peditor.class.php).


...\vendor\h5p\h5p-editor\h5peditor.class.php(543): H5peditor->mergeLocalLibsIntoCachedLibs(Array, Array)
#1 ...\vendor\h5p\h5p-editor\h5peditor-ajax.class.php(495): H5peditor->getLatestGlobalLibrariesData()
#2 ...\vendor\h5p\h5p-editor\h5peditor-ajax.class.php(116): H5PEditorAjax->getContentTypeCache(false)
#3 ...\modules\contrib\h5p\modules\h5peditor\src\Controller\H5PEditorAJAXController.php(27): H5PEditorAjax->action('content-type-ca...')
#4 [internal function]: Drupal\h5peditor\Controller\H5PEditorAJAXController->contentTypeCacheCallback()

Can anyone please confirm this as a bug and suggest the best way to remedy it.

Is it possible that the update of the h5p\h5p-editor package should have been accompanied by a update to the h5p-core ?

Thanks

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom SirClickALot Somerset

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @SirClickALot
  • 🇬🇧United Kingdom SirClickALot Somerset
  • 🇬🇧United Kingdom SirClickALot Somerset
  • 🇬🇧United Kingdom SirClickALot Somerset

    Can anyone please confirm or deny this please?

    When using PHP 8.1.15 if I roll back to Alpha (2.0.0-alpha4) version then the editor (sort of) works as expected but I get the following message appearing at the top of almost all pages...

    Deprecated: Optional parameter $prefix declared before required parameter $defaultLanguage is implicitly treated as a required parameter in <site>l\vendor\h5p\h5p-editor\h5peditor.class.php on line 376

    ... and often many of my pages don't render properly at all as a result.

    Can anyone please tell help me find a route to getting:

    1. A working, non-complaining version of H5P in Drupal 10.2.1 with PHP 8.1.15+
    2. A working H5P editor in Drupal 10.2.1 with PHP 8.1.15+

    Thanks in advance to anyone who can help; it can't just be me in this state of H5P Hell :-(

  • 🇨🇦Canada shaundychko

    After applying the merge request at 🐛 Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25 Needs work H5P is working on a new install, tested with creating an interactive video, on Drupal 10 with PHP 8 and H5P 1.26.

  • Status changed to Needs review 11 months ago
  • 🇨🇦Canada shaundychko

    Does applying the patch #8 at 🐛 Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25 Needs work close this issue?

Production build 0.71.5 2024