Add back "final" to Drupal\big_pipe\StackMiddleware\ContentLength

This might not be a drush issue? https://github.com/drush-ops/drush/issues/5848#issuecomment-1876021392

From this part of the exception thrown documented in 🐛 Uncaught exception thrown when running database updates via drush Active ,
```
Fatal error: Uncaught Symfony\Component\VarExporter\Exception\LogicException: Cannot generate lazy proxy: class "Drupal\big_pipe\StackMiddleware\ContentLength" is final. in /var/
www/html/vendor/symfony/var-exporter/ProxyHelper.php:92
Stack trace:
#0 /var/www/html/vendor/symfony/dependency-injection/LazyProxy/PhpDumper/LazyServiceDumper.php(136): Symfony\Component\VarExporter\ProxyHelper::generateLazyProxy(Object(Reflectio
nClass), Array)
#1 /var/www/html/vendor/symfony/dependency-injection/LazyProxy/Instantiator/LazyServiceInstantiator.php(33): Symfony\Component\DependencyInjection\LazyProxy\PhpDumper\LazyService
Dumper->getProxyCode(Object(Symfony\Component\DependencyInjection\Definition), 'http_middleware...')
#2 /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php(1086): Symfony\Component\DependencyInjection\LazyProxy\Instantiator\LazyServiceInstantiator->instantiate
```

Looked at Symfony docs for Lazy Services: https://symfony.com/doc/6.4/service_container/lazy_services.html, and saw this:

Lazy services do not support final classes, but you can use Interface Proxifying to work around this limitation.

In PHP versions prior to 8.0 lazy services do not support parameters with default values for built-in PHP classes (e.g. PDO).

Suggestion there is to use interface proxying:

# config/services.yaml
services:
    App\Twig\AppExtension:
        lazy: 'Twig\Extension\ExtensionInterface'
        # or a complete definition:
        lazy: true
        tags:
            - { name: 'proxy', interface: 'Twig\Extension\ExtensionInterface' }

Opened MR 6017 as experiment to use interface proxying per previous comment in the service declaration. Ran drush updb with this change and saw saw no exceptions thrown and updates ran successfully.

Not sure how to reproduce the exception otherwise, so leaving it here for now.

Turns out it's not a Drush-specific problem, and the error was not obvious on update.php because the exception was thrown during kernel->terminate() call after page was already sent to browser. Exception does show up in the log.

Updated IS. Updated MR with proposed approach and added a unit test.

Ran the test-only job

1) Drupal\Tests\Core\DependencyInjection\Compiler\StackedKernelPassTest::testProcessWithStackedKernelAndFinalHttpMiddleware
Cannot generate lazy proxy for service "http_kernel.two".
/builds/issue/drupal-3412168/core/tests/Drupal/Tests/Core/DependencyInjection/Compiler/StackedKernelPassTest.php:151
/builds/issue/drupal-3412168/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/issue/drupal-3412168/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3412168/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3412168/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3412168/vendor/phpunit/phpunit/src/TextUI/Command.php:97
FAILURES!
Tests: 3, Assertions: 15, Failures: 1.

Issue summary proposed solution match the fix.

Left a comment but that's just a curiosity and not a blocker if anyone see's that thread.

Change LGTM!

Tiny whitespace nitpick otherwise this looks good to me.

Fixed whitespace. Moving back to RTBC since that was the only thing.

Decided not to backport as this isn't critical, if someone is doing something strange in 10.2 we won't break their code but they will have to fix for 10.3.

Committed c10494d and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

godotislate → closed merge request !6017