- Issue created by @Ahmad Khader
- Status changed to RTBC
6 months ago 12:33pm 15 May 2024 - Status changed to Needs work
6 months ago 3:44pm 15 May 2024 - ๐ง๐ทBrazil renatog Campinas
Thanks for your contribution
Patch #2 is using
Drupal:service()
but this class has construct so it can use dependency injection - ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Merge request !37Issue #3412155: Fixed deprecated function system_get_module_admin_tasks error. โ (Open) created by manish-31
- Status changed to Needs review
6 months ago 1:58pm 27 May 2024 - ๐ฎ๐ณIndia manish-31
I have raised Merge Request for the patch from #2 including the feedback fixes from #4. Needs review.
I have confirmed that help page does not throw this error now.
- First commit to issue fork.
- ๐ซ๐ทFrance dydave
Hi Manish (@manish-31),
Thanks a lot for the merge request and code contributions.
According to the change record: system_get_module_admin_tasks() is deprecated โ as of D10.2.0 where the new service
system.module_admin_links_helper
was introduced and currently used in your merge request:
https://git.drupalcode.org/project/block_class/-/merge_requests/37/diffs...If we were to merge these changes we would be breaking backward compatibility (BC) and this feature would not work with D10.1, D10.0 or D9, which means we would have to drop support for 10.1 and only support 10.2 and above.
In order to get MR!37 merged, we're going to have to create the new minor release branch 2.1.x which will drop support for D10.1.
For the time being, the error mentioned in the issue summary has been fixed in related ticket ๐ Fix fatal 'TypeError: ModulePermissionsLinkHelper::getModulePermissionsLink(): Argument #2 ($name) must be of type string, array given' Fixed with changes committed to the 2.0.x branch.
We should be able to come back to this ticket soon... once we've got other non breaking changes added to the current 2.0.x branch.
Feel free to let us know if you have any questions or concerns on this comment or the ticket in general, we would surely be glad to help.
Thanks!