- Issue created by @pdureau
- Status changed to Needs work
11 months ago 9:39pm 4 January 2024 - π«π·France pdureau Paris
This issue has been fixed on UI Patterns 2.x side:
Unable to render component "ui_suite_uswds:collection_item". A render array or a scalar is expected for the slot "meta_items_list"
So let's remove it from the scope of this ticket.
However, I have found another one:
Unable to render component "ui_suite_uswds:language_selector". A render array or a scalar is expected for the slot "items" when using the render element with the "#slots" property
I am suggesting:
settings: items: type: links label: "Language buttons" preview: - title: English" url: "/" attributes: lang: en - title: Spanish" url: "/es" attributes: lang: es - title: French" url: "/fr" attributes: lang: fr
Don't forget to change the Twig template too.
And I doubt the lang attributes is expected in this example. According to https://designsystem.digital.gov/components/language-selector/ lang and xml:lang are expected when the label is in the targeted language, not when in English.
Anyway, it is nice to manipulate the attributes object for each item, because it will be filled by Drupal if needed, and it is nice to duplicate the value for
xml:lang
as you already doing. - Assigned to pdureau
- Status changed to Postponed
10 months ago 12:25pm 26 January 2024 - π«π·France pdureau Paris
i keep on my side, and will do a new conversion test when UI Patterns 2.x will hit a development milestone
- π«π·France pdureau Paris
Monthly update: https://git.drupalcode.org/project/ui_suite_uswds/-/commit/5badac4cb9c97...
Only one remaining issue:
Unable to render component "ui_suite_uswds:table". A render array or a scalar is expected for the slot "header"
Let's check what UI Suite Bootstrap is planning to do.
- π«π·France mogtofu33
Some minor errors left (detected with ui_patterns_devel):
Component: ui_suite_uswds:in_page_nav [heading_selectors[0]] Does not have a value in the enumeration [2,3,4,5,6] [heading_selectors[1]] Does not have a value in the enumeration [2,3,4,5,6] Component: ui_suite_uswds:grid_row [card] Does not have a value in the enumeration [...] [mobile_lg] Does not have a value in the enumeration [...] [tablet_lg] Does not have a value in the enumeration [...] [desktop_lg] Does not have a value in the enumeration [...] [widescreen] Does not have a value in the enumeration [...] Component: ui_suite_uswds:button [url] NULL value found, but a string or an object is required. This may be because the property is empty instead of having data present. If possible fix the source data, use the |default() twig filter, or update the schema to allow multiple types.
- π«π·France pdureau Paris
Component: ui_suite_uswds:grid_row
[card] Does not have a value in the enumeration [...]
[mobile_lg] Does not have a value in the enumeration [...]
[tablet_lg] Does not have a value in the enumeration [...]
[desktop_lg] Does not have a value in the enumeration [...]
[widescreen] Does not have a value in the enumeration [...]Already fixed on UI Patterns 2.x (legacy module) side.
Component: ui_suite_uswds:in_page_nav
[heading_selectors[0]] Does not have a value in the enumeration [2,3,4,5,6]
[heading_selectors[1]] Does not have a value in the enumeration [2,3,4,5,6]Need to be fixed on UI Patterns 2.x (legacy module) side: cast the preview value according to the prop type.
Component: ui_suite_uswds:button
[url] NULL value found, but a string or an object is required. This may be because the property is empty instead of having data present. If possible fix the source data, use the |default() twig filter, or update the schema to allow multiple types.I don't understand because it looks OK:
props: url: 'https://example.com'
- Status changed to Needs work
4 months ago 5:21pm 11 July 2024 -
smustgrave β
committed f50c9631 on 4.0.x
Issue #3412077: Automatic conversion to SDC & UI Patterns 2.x
-
smustgrave β
committed f50c9631 on 4.0.x
- Status changed to Fixed
4 months ago 1:23pm 2 August 2024 - πΊπΈUnited States smustgrave
Will open up some follow ups following internal testing
Automatically closed - issue fixed for 2 weeks with no activity.