Empty 'li" is getting added

Created on 2 January 2024, 6 months ago
Updated 16 January 2024, 5 months ago

Problem/Motivation

While I was testing out the theme I found out that while adding the comment for the article empty "li" is getting added

Steps to reproduce

Enable the revolt theme and create some articles and tags and then try to add the comment to any of the articles after the comment is added you will see the empty li is being added.

Proposed resolution

To fix the same we can prevent the action by which the empty li is being added.

Remaining tasks

None

User interface changes

Yes there may be some UI changes involved in the process of fixing the issue

API changes

none

Data model changes

none

🐛 Bug report
Status

Closed: won't fix

Version

2.1

Component

Code

Created by

🇮🇳India Hamid.ali

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Hamid.ali
  • 🇮🇳India Hamid.ali

    Here is the screenshot for the same

  • 🇮🇳India sourabhjain

    @hamid.ali Thanks for reporting the issue and found the issue is persist so I have investigate more on it and get to know that the link is showing when the history module is enabled and the code is written in

    web/core/themes/olivero/templates/navigation/links.html.twig
    
    if ($this->moduleHandler->moduleExists('history')) {
                    $links['comment-new-comments'] = [
                      'title' => '',
                      'url' => Url::fromRoute('<current>'),
                      'attributes' => [
                        'class' => 'hidden',
                        'title' => $this->t('Jump to the first new comment.'),
                        'data-history-node-last-comment-timestamp' => $entity->get($field_name)->last_comment_timestamp,
                        'data-history-node-field-name' => $field_name,
                      ],
                    ];
                  }

    So we need to investigate it further as the same issue is coming in other contrib themes too.

  • Status changed to Closed: won't fix 5 months ago
Production build 0.69.0 2024