Contrib.social

Add a formatter to represent JSON data in human readable form

Open on Drupal.org →
Created on 31 December 2023, about 1 year ago
Updated 21 June 2024, 9 months ago
✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇷🇺Russia Chi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Chi
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update about 1 year ago
    17 pass
  • Comment about 1 year ago →
    🇷🇺Russia Chi
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update about 1 year ago
    17 pass
  • Comment about 1 year ago →
    🇷🇺Russia Chi

    Added formatting for boolean properties.

  • Comment 10 months ago →
    🇺🇸United States DamienMcKenna NH, USA

    This looks good, thank you!

  • First commit to issue fork.
  • Merge request !25MR of patch #3 https://www.drupal.org/project/json_field/issues/3411495#comment-15459697 → (Merged) created by ptmkenny
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 10 months ago
    17 pass
  • Comment 10 months ago →
    🇯🇵Japan ptmkenny

    Created MR so that this can be tested with GitLab CI. This is the patch in #3 with no changes; all credit should go to Chi.

  • Pipeline finished with Failed
    10 months ago
    Total: 242s
    #183266
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 10 months ago
    17 pass
  • Pipeline finished with Failed
    10 months ago
    Total: 180s
    #183405
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 10 months ago
    17 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 10 months ago
    17 pass
  • Pipeline finished with Failed
    10 months ago
    Total: 261s
    #183437
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 10 months ago
    17 pass
  • Pipeline finished with Canceled
    10 months ago
    Total: 59s
    #183448
  • Pipeline finished with Failed
    10 months ago
    Total: 148s
    #183451
  • Comment 10 months ago →
    🇯🇵Japan ptmkenny

    I fixed the issues identified by cspell, phpcs, and stylelint and synced the branch.

  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇯🇵Japan ptmkenny

    Unit tests are failing on Drupal 9:

    There were 2 errors:
1) Drupal\Tests\json_field\Kernel\PrettyElementTest::testElement
TypeError: Argument 1 passed to Drupal\json_field\Element\JsonPretty::formatJson() must be an instance of Drupal\json_field\Element\mixed, instance of stdClass given, called in /builds/issue/json_field-3411495/src/Element/JsonPretty.php on line 31
/builds/issue/json_field-3411495/src/Element/JsonPretty.php:40
/builds/issue/json_field-3411495/src/Element/JsonPretty.php:31
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php:101
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:788
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:374
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:204
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:160
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:580
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:161
/builds/issue/json_field-3411495/tests/src/Kernel/PrettyElementTest.php:59
/builds/issue/json_field-3411495/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
2) Drupal\Tests\json_field\Kernel\PrettyFormatterTest::testFormatter
TypeError: Argument 1 passed to Drupal\json_field\Element\JsonPretty::formatJson() must be an instance of Drupal\json_field\Element\mixed, instance of stdClass given, called in /builds/issue/json_field-3411495/src/Element/JsonPretty.php on line 31
/builds/issue/json_field-3411495/src/Element/JsonPretty.php:40
/builds/issue/json_field-3411495/src/Element/JsonPretty.php:31
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php:101
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:788
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:374
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:446
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:446
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:204
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:160
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:580
/builds/issue/json_field-3411495/web/core/lib/Drupal/Core/Render/Renderer.php:161
/builds/issue/json_field-3411495/tests/src/Kernel/PrettyFormatterTest.php:36
/builds/issue/json_field-3411495/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
ERRORS!
Tests: 17, Assertions: 96, Errors: 2.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 9 months ago
    17 pass
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇺🇸United States DamienMcKenna NH, USA

    I removed the "mixed" argument type and added docs to the method, hopefully it'll work now.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 9 months ago
    17 pass
  • Comment 9 months ago →
    System Message
  • Status changed to Fixed 9 months ago
  • Comment 9 months ago →
    🇺🇸United States DamienMcKenna NH, USA

    Committed. Thanks everyone!

  • Comment 9 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024