Contrib.social

Fix stylelint violations

Open on Drupal.org →
Created on 29 December 2023, over 1 year ago
Updated 30 July 2024, 10 months ago

Problem/Motivation

Comand:

$ yarn --silent --cwd . stylelint --formatter verbose --config ./.stylelintrc.json ../modules/custom/token/**/*.css --color

Result:

../modules/custom/token-3411331/css/jquery.treetable.css
  8:3  ✖  Expected "user-select" to come before "text-align"                  order/properties-order
  9:3  ✖  Expected "-khtml-user-select" to come before "user-select"          order/properties-order
 15:3  ✖  Expected "-webkit-box-sizing" to come before "-webkit-user-select"  order/properties-order
 19:3  ✖  Unexpected empty line before declaration                            declaration-empty-line-before
 24:3  ✖  Expected "background-repeat" to come before "background-position"   order/properties-order
 25:3  ✖  Expected "display" to come before "background-repeat"               order/properties-order
 27:3  ✖  Expected "width" to come before "text-decoration"                   order/properties-order
../modules/custom/token-3411331/css/token.css
 9:3  ✖  Expected "margin-left" to come before "font-size"  order/properties-order
../modules/custom/token-3411331/css/token.treetable.theme.css
  1:17  ✖  Unexpected empty block                                             block-no-empty
  4:25  ✖  Unexpected empty block                                             block-no-empty
  7:23  ✖  Unexpected empty block                                             block-no-empty
 10:29  ✖  Unexpected empty block                                             block-no-empty
 19:3   ✖  Expected "background-repeat" to come before "background-position"  order/properties-order
 20:3   ✖  Expected "padding" to come before "background-repeat"              order/properties-order
 37:3   ✖  Expected "color" to come before "background-color"                 order/properties-order
 49:3   ✖  Expected "color" to come before "background-color"                 order/properties-order
16 problems (16 errors, 0 warnings)
3 sources checked
 /builds/issue/token-3411331/web/modules/custom/token-3411331/css/jquery.treetable.css
 /builds/issue/token-3411331/web/modules/custom/token-3411331/css/token.css
 /builds/issue/token-3411331/web/modules/custom/token-3411331/css/token.treetable.theme.css
16 errors found
 order/properties-order: 11
 declaration-empty-line-before: 1 (maybe fixable)
 block-no-empty: 4

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇷🇺Russia zniki.ru

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @zniki.ru
  • Merge request !60Resolve #3411336 "Fix stylelint violations" → (Open) created by zniki.ru
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MariaDB 10.3.22
    last update over 1 year ago
    77 pass
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇷🇺Russia zniki.ru

    MR is ready for review.

  • Pipeline finished with Success
    over 1 year ago
    Total: 264s
    #69511
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India d-xpert Chandigarh

    @Nikolay Shapovalov, I have thoroughly reviewed your CSS changes for the style lint, and they have successfully addressed all style lint errors. The latest pipeline run does not report any new style lint errors.
    Moving this issue to RTBC

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update about 1 year ago
    78 pass
  • Pipeline finished with Success
    about 1 year ago
    Total: 303s
    #155737
  • First commit to issue fork.
  • Pipeline finished with Success
    10 months ago
    Total: 149s
    #238097
  • Pipeline finished with Success
    10 months ago
    Total: 182s
    #238117
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇫🇷France dydave

    Quick follow-up on this issue:

    • Rebased MR!60 to trigger automated testing which prompted some more errors with stylelint.
    • Fixed at #6 remaining errors reported.
    • Re-ran pipeline with stylelint completing successfully.

     
    We've added to GitLab CI configuration a requirement on the stylelint job to pass, but assume it should be up to the maintainer whether this requirement on the build should be kept.
     
    We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!60 and let us know if there would be any more work needed.
     
    Feel free to let us know if you have any questions or concerns on merge request MR!60 or any aspect of this ticket in general, we would surely be glad to help.
    Thanks in advance for your feedback and reviews.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024