Problem/Motivation
Source https://git.drupalcode.org/project/token/-/jobs/531106
Command:
../../../core/node_modules/.bin/eslint --no-error-on-unmatched-pattern --ignore-pattern="*.es6.js" --resolve-plugins-relative-to=../../../core --ext=.js,.yml .
Result:
/builds/project/token/web/modules/custom/token/drush.services.yml
7:8 error Expected indentation of 1 spaces but found 2 spaces yml/indent
/builds/project/token/web/modules/custom/token/js/jquery.treetable.js
8:2 warning Unexpected unnamed function func-names
8:10 error Insert `·` prettier/prettier
9:3 error Split 'var' declarations into multiple statements one-var
9:3 error Unexpected var, use let or const instead no-var
11:11 warning Unexpected unnamed function func-names
11:19 error Insert `·` prettier/prettier
12:14 error 'Node' is already declared in the upper scope on line 9 column 7 no-shadow
13:7 error Unexpected var, use let or const instead no-var
24:44 error Replace `""` with `''` prettier/prettier
28:25 error Replace `this.row.children(this.settings.columnElType)[this.settings.column]` with `⏎········this.row.children(this.settings.columnElType)[this.settings.column],⏎······` prettier/prettier
36:31 warning Unexpected unnamed function func-names
36:39 error Insert `·` prettier/prettier
40:32 warning Unexpected unnamed function func-names
40:40 error Insert `·` prettier/prettier
41:7 error Split 'var' declarations into multiple statements one-var
41:7 error Unexpected var, use let or const instead no-var
44:14 error Replace `node·=·node.parentNode(` with `(node·=·node.parentNode()` prettier/prettier
44:14 error Unexpected assignment within a 'while' statement no-cond-assign
50:31 warning Unexpected unnamed function func-names
50:39 error Insert `·` prettier/prettier
55:28 error Replace `"expanded").addClass("collapsed"` with `'expanded').addClass('collapsed'` prettier/prettier
58:26 error Replace `"title"` with `'title'` prettier/prettier
67:32 warning Unexpected unnamed function func-names
67:40 error Insert `·` prettier/prettier
68:32 error Replace `"collapsed"` with `'collapsed'` prettier/prettier
73:29 warning Unexpected unnamed function func-names
73:37 error Insert `·` prettier/prettier
78:28 error Replace `"collapsed").addClass("expanded"` with `'collapsed').addClass('expanded'` prettier/prettier
84:26 error Replace `":visible"` with `':visible'` prettier/prettier
88:26 error Replace `"title"` with `'title'` prettier/prettier
93:31 warning Unexpected unnamed function func-names
93:39 error Insert `·` prettier/prettier
94:32 error Replace `"expanded"` with `'expanded'` prettier/prettier
97:27 warning Unexpected unnamed function func-names
97:35 error Insert `·` prettier/prettier
103:35 warning Unexpected unnamed function func-names
103:43 error Insert `·` prettier/prettier
104:9 error Replace `(this.children.length·>·0·||·this.row.data(this.settings.branchAttr)·===·true` with `·(⏎········this.children.length·>·0·||⏎········this.row.data(this.settings.branchAttr)·===·true⏎······` prettier/prettier
106:14 error Unnecessary 'else' after 'return' no-else-return
111:44 warning Unexpected unnamed function func-names
111:52 error Replace `()` with `·()·` prettier/prettier
117:28 warning Unexpected unnamed function func-names
117:36 error Insert `·` prettier/prettier
121:33 warning Unexpected unnamed function func-names
121:41 error Insert `·` prettier/prettier
124:14 error Unnecessary 'else' after 'return' no-else-return
129:34 warning Unexpected unnamed function func-names
129:42 error Insert `·` prettier/prettier
130:7 error Unexpected var, use let or const instead no-var
131:40 error Insert `;` prettier/prettier
134:29 warning Unexpected unnamed function func-names
134:37 error Insert `·` prettier/prettier
135:7 error Split 'var' declarations into multiple statements one-var
135:7 error Unexpected var, use let or const instead no-var
136:1 error Replace `··········` with `········` prettier/prettier
136:11 error Use object destructuring prefer-destructuring
137:1 error Delete `··` prettier/prettier
140:19 warning Unexpected unnamed function func-names
140:27 error Insert `·` prettier/prettier
141:18 error Replace `.parents("table").treetable("node",·$(this).parents("tr").data(settings.nodeIdAttr))` with `⏎············.parents('table')⏎············.treetable('node',·$(this).parents('tr').data(settings.nodeIdAttr))⏎············` prettier/prettier
146:17 error Insert `⏎·········` prettier/prettier
148:20 error Replace `"click.treetable").on("click.treetable"` with `'click.treetable').on('click.treetable'` prettier/prettier
149:20 error Replace `"keydown.treetable").on("keydown.treetable",·function` with `'keydown.treetable').on('keydown.treetable',·function·` prettier/prettier
149:65 warning Unexpected unnamed function func-names
150:25 error Expected '===' and instead saw '==' eqeqeq
156:43 error Replace `·""·+·(this.level()·*·settings.indent)·+·"px"` with `⏎········''·+·this.level()·*·settings.indent·+·'px'` prettier/prettier
156:44 error Unexpected string concatenation prefer-template
161:29 warning Unexpected unnamed function func-names
161:37 error Insert `·` prettier/prettier
168:32 warning Unexpected unnamed function func-names
168:40 error Insert `·` prettier/prettier
177:27 warning Unexpected unnamed function func-names
177:35 error Insert `·` prettier/prettier
188:29 warning Unexpected unnamed function func-names
188:37 error Insert `·` prettier/prettier
197:36 warning Unexpected unnamed function func-names
197:44 error Insert `·` prettier/prettier
198:7 error Split 'var' declarations into multiple statements one-var
198:7 error Unexpected var, use let or const instead no-var
208:34 warning Unexpected unnamed function func-names
208:42 error Insert `·` prettier/prettier
209:7 error Unexpected var, use let or const instead no-var
209:11 error Use object destructuring prefer-destructuring
213:11 error Replace `settings.expandable·===·true·&&·settings.initialState·===·"collapsed"` with `⏎········settings.expandable·===·true·&&⏎········settings.initialState·===·'collapsed'⏎······` prettier/prettier
223:7 error Return statement should not contain assignment no-return-assign
223:14 error Replace `this.initialized·=·true` with `(this.initialized·=·true)` prettier/prettier
226:36 warning Unexpected unnamed function func-names
226:44 error Insert `·` prettier/prettier
227:7 error Split 'var' declarations into multiple statements one-var
227:7 error Unexpected var, use let or const instead no-var
240:11 warning Unexpected unnamed function func-names
240:19 error Insert `·` prettier/prettier
241:14 error 'Tree' is already declared in the upper scope on line 9 column 13 no-shadow
251:34 warning Unexpected unnamed function func-names
251:42 error Insert `·` prettier/prettier
252:7 error Split 'var' declarations into multiple statements one-var
252:7 error Unexpected var, use let or const instead no-var
262:32 warning Unexpected unnamed function func-names
262:40 error Insert `·` prettier/prettier
263:7 error Split 'var' declarations into multiple statements one-var
263:7 error Unexpected var, use let or const instead no-var
273:35 warning Unexpected unnamed function func-names
276:14 error Unnecessary 'else' after 'return' no-else-return
281:31 warning Unexpected unnamed function func-names
281:39 error Insert `·` prettier/prettier
282:7 error Split 'var' declarations into multiple statements one-var
282:7 error Unexpected var, use let or const instead no-var
309:27 warning Unexpected unnamed function func-names
309:35 error Insert `·` prettier/prettier
317:7 error Unexpected var, use let or const instead no-var
318:11 error Replace `node·!==·destination·&&·destination.id·!==·node.parentId·&&·$.inArray(node,·destination.ancestors())·===·-1` with `⏎········node·!==·destination·&&⏎········destination.id·!==·node.parentId·&&⏎········$.inArray(node,·destination.ancestors())·===·-1⏎······` prettier/prettier
329:9 error Replace `(nodeParent)` with `·(nodeParent)·` prettier/prettier
332:9 error Replace `(node.parentNode())` with `·(node.parentNode())·` prettier/prettier
339:33 warning Unexpected unnamed function func-names
339:41 error Insert `·` prettier/prettier
356:6 error Insert `;` prettier/prettier
358:29 warning Unexpected unnamed function func-names
358:37 error Insert `·` prettier/prettier
359:7 error Split 'var' declarations into multiple statements one-var
359:7 error Unexpected var, use let or const instead no-var
371:33 warning Unexpected unnamed function func-names
371:41 error Insert `·` prettier/prettier
381:35 warning Unexpected unnamed function func-names
381:43 error Insert `·` prettier/prettier
385:7 error Split 'var' declarations into multiple statements one-var
385:7 error Unexpected var, use let or const instead no-var
386:9 error Delete `··` prettier/prettier
400:32 warning Unexpected unnamed function func-names
400:40 error Insert `·` prettier/prettier
401:7 error Split 'var' declarations into multiple statements one-var
401:7 error Unexpected var, use let or const instead no-var
401:11 error Use object destructuring prefer-destructuring
401:36 error Insert `⏎·······` prettier/prettier
414:37 warning Unexpected unnamed function func-names
414:45 error Insert `·` prettier/prettier
423:5 warning Unexpected unnamed method 'init' func-names
423:5 error Expected method shorthand object-shorthand
423:19 error Insert `·` prettier/prettier
424:7 error Unexpected var, use let or const instead no-var
426:27 error Insert `⏎········` prettier/prettier
427:1 error Replace `········branchAttr:·"ttBranch"` with `··········branchAttr:·'ttBranch'` prettier/prettier
428:9 error Insert `··` prettier/prettier
429:9 error Insert `··` prettier/prettier
430:1 error Replace `········columnElType:·"td"` with `··········columnElType:·'td'` prettier/prettier
431:9 error Insert `··` prettier/prettier
432:1 error Insert `··` prettier/prettier
433:9 error Insert `··` prettier/prettier
434:1 error Insert `··` prettier/prettier
435:9 error Replace `initialState:·"collapsed"` with `··initialState:·'collapsed'` prettier/prettier
436:1 error Replace `········nodeIdAttr:·"ttId"` with `··········nodeIdAttr:·'ttId'` prettier/prettier
437:9 error Replace `parentIdAttr:·"ttParentId"` with `··parentIdAttr:·'ttParentId'` prettier/prettier
438:1 error Replace `········stringExpand:·"Expand"` with `··········stringExpand:·'Expand'` prettier/prettier
439:9 error Replace `stringCollapse:·"Collapse"` with `··stringCollapse:·'Collapse'` prettier/prettier
441:1 error Insert `··` prettier/prettier
442:1 error Replace `········` with `··········` prettier/prettier
443:1 error Insert `··` prettier/prettier
444:1 error Replace `········` with `··········` prettier/prettier
445:1 error Replace `········onNodeInitialized:·null` with `··········onNodeInitialized:·null,` prettier/prettier
446:1 error Replace `······},·options` with `········},⏎········options,⏎······` prettier/prettier
448:24 warning Unexpected unnamed function func-names
448:32 error Insert `·` prettier/prettier
449:9 error Split 'var' declarations into multiple statements one-var
449:9 error Unexpected var, use let or const instead no-var
449:26 error Insert `⏎·········` prettier/prettier
451:30 error Replace `"treetable"` with `'treetable'` prettier/prettier
455:23 error Replace `"treetable").data("treetable"` with `'treetable').data('treetable'` prettier/prettier
466:5 warning Unexpected unnamed method 'destroy' func-names
466:5 error Expected method shorthand object-shorthand
466:22 error Insert `·` prettier/prettier
467:24 warning Unexpected unnamed function func-names
467:32 error Insert `·` prettier/prettier
468:35 error Replace `"treetable").removeClass("treetable"` with `'treetable').removeClass('treetable'` prettier/prettier
472:5 warning Unexpected unnamed method 'collapseAll' func-names
472:5 error Expected method shorthand object-shorthand
472:26 error Insert `·` prettier/prettier
473:17 error Replace `"treetable"` with `'treetable'` prettier/prettier
477:5 warning Unexpected unnamed method 'collapseNode' func-names
477:5 error Expected method shorthand object-shorthand
477:27 error Insert `·` prettier/prettier
478:7 error Unexpected var, use let or const instead no-var
478:28 error Replace `"treetable"` with `'treetable'` prettier/prettier
483:25 error Unexpected string concatenation prefer-template
489:5 warning Unexpected unnamed method 'expandAll' func-names
489:5 error Expected method shorthand object-shorthand
489:24 error Insert `·` prettier/prettier
490:17 error Replace `"treetable"` with `'treetable'` prettier/prettier
494:5 warning Unexpected unnamed method 'expandNode' func-names
494:5 error Expected method shorthand object-shorthand
494:25 error Insert `·` prettier/prettier
495:7 error Unexpected var, use let or const instead no-var
495:28 error Replace `"treetable"` with `'treetable'` prettier/prettier
504:25 error Unexpected string concatenation prefer-template
510:5 warning Unexpected unnamed method 'loadBranch' func-names
510:5 error Expected method shorthand object-shorthand
510:25 error Insert `·` prettier/prettier
511:7 error Split 'var' declarations into multiple statements one-var
511:7 error Unexpected var, use let or const instead no-var
511:11 error Use object destructuring prefer-destructuring
511:32 error Replace `"treetable"` with `'treetable'` prettier/prettier
512:9 error Replace `··tree·=·this.data("treetable"` with `tree·=·this.data('treetable'` prettier/prettier
512:11 error Use object destructuring prefer-destructuring
517:26 error Insert `⏎·······` prettier/prettier
520:9 error All 'var' declarations must be at the top of the function scope vars-on-top
520:9 error Unexpected var, use let or const instead no-var
520:34 error Replace `"treetable"` with `'treetable'` prettier/prettier
524:17 error Replace `"treetable"` with `'treetable'` prettier/prettier
527:19 error Replace `"tr").each(function` with `'tr').each(function·` prettier/prettier
527:30 warning Unexpected unnamed function func-names
539:5 warning Unexpected unnamed method 'move' func-names
539:5 error Expected method shorthand object-shorthand
539:19 error Insert `·` prettier/prettier
540:7 error Split 'var' declarations into multiple statements one-var
540:7 error Unexpected var, use let or const instead no-var
542:24 error Replace `"treetable"` with `'treetable'` prettier/prettier
543:31 error Replace `"treetable"` with `'treetable'` prettier/prettier
544:17 error Replace `"treetable"` with `'treetable'` prettier/prettier
549:5 warning Unexpected unnamed method 'node' func-names
549:5 error Expected method shorthand object-shorthand
549:19 error Insert `·` prettier/prettier
550:24 error Replace `"treetable"` with `'treetable'` prettier/prettier
553:5 warning Unexpected unnamed method 'removeNode' func-names
553:5 error Expected method shorthand object-shorthand
553:25 error Insert `·` prettier/prettier
554:7 error Unexpected var, use let or const instead no-var
554:28 error Replace `"treetable"` with `'treetable'` prettier/prettier
557:19 error Replace `"treetable"` with `'treetable'` prettier/prettier
559:25 error Unexpected string concatenation prefer-template
565:5 warning Unexpected unnamed method 'reveal' func-names
565:5 error Expected method shorthand object-shorthand
565:21 error Insert `·` prettier/prettier
566:7 error Unexpected var, use let or const instead no-var
566:28 error Replace `"treetable"` with `'treetable'` prettier/prettier
571:25 error Unexpected string concatenation prefer-template
577:5 warning Unexpected unnamed method 'sortBranch' func-names
577:5 error Expected method shorthand object-shorthand
577:25 error Insert `·` prettier/prettier
578:7 error Split 'var' declarations into multiple statements one-var
578:7 error Unexpected var, use let or const instead no-var
578:11 error Use object destructuring prefer-destructuring
578:32 error Replace `"treetable"` with `'treetable'` prettier/prettier
579:9 error Delete `··` prettier/prettier
579:11 warning 'prepValue' is defined but never used no-unused-vars
580:1 error Replace `··········` with `········` prettier/prettier
586:19 warning Unexpected unnamed function func-names
586:27 error Insert `·` prettier/prettier
587:11 error Split 'var' declarations into multiple statements one-var
587:11 error Unexpected var, use let or const instead no-var
589:26 warning Unexpected unnamed function func-names
589:34 error Insert `·` prettier/prettier
589:35 error 'node' is already declared in the upper scope on line 577 column 26 no-shadow
590:13 error Unexpected var, use let or const instead no-var
590:37 error Replace `"td:eq("·+·columnOrFunction·+·")"` with `'td:eq('·+·columnOrFunction·+·')'` prettier/prettier
590:37 error Unexpected string concatenation prefer-template
594:12 error Insert `;` prettier/prettier
605:17 error Replace `"treetable"` with `'treetable'` prettier/prettier
609:5 warning Unexpected unnamed method 'unloadBranch' func-names
609:5 error Expected method shorthand object-shorthand
609:27 error Insert `·` prettier/prettier
610:17 error Replace `"treetable"` with `'treetable'` prettier/prettier
612:6 error Insert `,` prettier/prettier
615:20 warning Unexpected unnamed function func-names
615:28 error Insert `·` prettier/prettier
617:36 error Replace `this,·Array.prototype.slice.call(arguments,·1)` with `⏎········this,⏎········Array.prototype.slice.call(arguments,·1),⏎······` prettier/prettier
617:69 error Use the rest parameters instead of 'arguments' prefer-rest-params
618:12 error Unnecessary 'else' after 'return' no-else-return
619:39 error Use the rest parameters instead of 'arguments' prefer-rest-params
621:22 error Replace `"Method·"·+·method·+·"·does·not·exist·on·jQuery.treetable"` with `⏎········'Method·'·+·method·+·'·does·not·exist·on·jQuery.treetable',⏎······` prettier/prettier
621:22 error Unexpected string concatenation prefer-template
626:3 error Expected an assignment or function call and instead saw an expression no-unused-expressions
/builds/project/token/web/modules/custom/token/js/token.js
1:1 error Replace `⏎(function·($,·Drupal,·drupalSettings)·{⏎` with `(function·($,·Drupal,·drupalSettings)·{` prettier/prettier
2:2 warning Unexpected unnamed function func-names
4:3 error 'use strict' is unnecessary inside of modules strict
7:5 warning Unexpected unnamed method 'attach' func-names
7:5 error Expected method shorthand object-shorthand
7:32 warning 'settings' is defined but never used no-unused-vars
8:69 error Replace `·expandable:·true` with `⏎········expandable:·true,⏎······` prettier/prettier
9:6 error Insert `,` prettier/prettier
13:5 warning Unexpected unnamed method 'attach' func-names
13:5 error Expected method shorthand object-shorthand
13:32 warning 'settings' is defined but never used no-unused-vars
15:56 warning Unexpected unnamed function func-names
20:43 warning Unexpected unnamed function func-names
21:43 error Replace `'change:isFocused',` with `⏎············'change:isFocused',⏎···········` prettier/prettier
22:13 error Insert `··` prettier/prettier
23:1 error Insert `··` prettier/prettier
24:13 error Insert `··` prettier/prettier
25:11 error Replace `}` with `··},⏎··········` prettier/prettier
26:11 error Insert `;` prettier/prettier
29:12 error Replace `'token-click-insert',·'.token-click-insert·.token-key',·context` with `⏎········'token-click-insert',⏎········'.token-click-insert·.token-key',⏎········context,⏎······` prettier/prettier
29:85 warning Unexpected unnamed function func-names
30:9 error Unexpected var, use let or const instead no-var
30:25 error Replace `'<a·href="javascript:void(0);"·title="'·+·Drupal.t('Insert·this·token·into·your·form')·+·'">'·+·$(token).html()·+·'</a>'` with `⏎··········'<a·href="javascript:void(0);"·title="'·+⏎············Drupal.t('Insert·this·token·into·your·form')·+⏎············'">'·+⏎············$(token).html()·+⏎············'</a>',⏎········` prettier/prettier
30:25 error Unexpected string concatenation prefer-template
30:153 warning Unexpected unnamed function func-names
31:11 error Unexpected var, use let or const instead no-var
34:15 error Replace `drupalSettings.tokenFocusedField·&&·(drupalSettings.tokenFocusedField.tokenDialogFocus·||·drupalSettings.tokenFocusedField.tokenHasFocus)` with `⏎············drupalSettings.tokenFocusedField·&&⏎············(drupalSettings.tokenFocusedField.tokenDialogFocus·||⏎··············drupalSettings.tokenFocusedField.tokenHasFocus)⏎··········` prettier/prettier
35:13 error 'insertAtCursor' was used before it was defined no-use-before-define
38:26 error Replace `(tinyMCE)` with `·tinyMCE` prettier/prettier
38:36 error Expected '!==' and instead saw '!=' eqeqeq
38:54 error 'tinyMCE' is not defined no-undef
39:13 error 'tinyMCE' is not defined no-undef
39:46 error Replace `'mceInsertContent',·false,·content` with `⏎··············'mceInsertContent',⏎··············false,⏎··············content,⏎············` prettier/prettier
43:26 error Replace `(CKEDITOR)` with `·CKEDITOR` prettier/prettier
43:37 error Expected '!==' and instead saw '!=' eqeqeq
43:55 error 'CKEDITOR' is not defined no-undef
44:13 error 'CKEDITOR' is not defined no-undef
47:20 error Replace `typeof(CodeMirror)·!=·'undefined'·&&·drupalSettings.tokenFocusedField·&&·$(drupalSettings.tokenFocusedField).parents('.CodeMirror').length` with `⏎············typeof·CodeMirror·!=·'undefined'·&&⏎············drupalSettings.tokenFocusedField·&&⏎············$(drupalSettings.tokenFocusedField).parents('.CodeMirror').length⏎··········` prettier/prettier
47:39 error Expected '!==' and instead saw '!=' eqeqeq
48:13 error All 'var' declarations must be at the top of the function scope vars-on-top
48:13 error Unexpected var, use let or const instead no-var
48:70 error Replace `'.CodeMirror'` with `⏎··············'.CodeMirror',⏎············` prettier/prettier
54:78 error Insert `;` prettier/prettier
57:20 error Replace `typeof(CKEDITOR)·!=·'undefined'·&&·typeof(Drupal.ckeditorActiveId)·!=·'undefined'` with `⏎············typeof·CKEDITOR·!=·'undefined'·&&⏎············typeof·Drupal.ckeditorActiveId·!=·'undefined'⏎··········` prettier/prettier
57:37 error Expected '!==' and instead saw '!=' eqeqeq
57:87 error Expected '!==' and instead saw '!=' eqeqeq
58:13 error 'CKEDITOR' is not defined no-undef
59:12 error Delete `⏎·········` prettier/prettier
61:13 error 'insertAtCursor' was used before it was defined no-use-before-define
62:12 error Delete `⏎·········` prettier/prettier
64:19 error 'editor' is already declared in the upper scope on line 48 column 17 no-shadow
67:17 error Delete `··` prettier/prettier
68:1 error Delete `··` prettier/prettier
70:15 error Insert `;` prettier/prettier
71:12 error Delete `⏎·········` prettier/prettier
73:13 warning Unexpected alert no-alert
73:19 error Replace `Drupal.t('First·click·a·text·field·to·insert·your·tokens·into.')` with `⏎··············Drupal.t('First·click·a·text·field·to·insert·your·tokens·into.'),⏎············` prettier/prettier
83:9 error Unexpected var, use let or const instead no-var
88:11 error All 'var' declarations must be at the top of the function scope vars-on-top
88:11 error Unexpected var, use let or const instead no-var
93:65 error Expected '===' and instead saw '==' eqeqeq
94:11 error All 'var' declarations must be at the top of the function scope vars-on-top
94:11 error Unexpected var, use let or const instead no-var
95:11 error All 'var' declarations must be at the top of the function scope vars-on-top
95:11 error Unexpected var, use let or const instead no-var
96:25 error Replace `·editor.value.substring(0,·startPos)·+·content·+` with `⏎············editor.value.substring(0,·startPos)·+⏎············content·+⏎···········` prettier/prettier
107:6 error Insert `,` prettier/prettier
108:5 error Delete `⏎` prettier/prettier
✖ 338 problems (272 errors, 66 warnings)
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes