- Issue created by @khoebeke
- Status changed to Needs review
12 months ago 5:10am 28 December 2023 - 🇮🇳India viren18febS
I have updated the core versions for Drupal10 & added patch, please review.
- Status changed to Needs work
12 months ago 7:26am 28 December 2023 - 🇮🇳India Tirupati_Singh
Hi @viren18febS, I've applied your patch #2 and the module is being install on Drupal 10. But on uninstalling the module I'm getting following error. I'm attaching the screenshot for your reference.
The website encountered an unexpected error. Please try again later. Error: Call to undefined function drupal_uninstall_schema() in news_ticker_uninstall() (line 106 of modules/custom/news_ticker/news_ticker.install).
- 🇮🇳India dineshkumarbollu
drupal_uninstall_schema()
method also a Drupal 10 deprecation, need to add schema to drop tables. - Merge request !13411080-d10-port: Upgraded module to Drupal 10. → (Merged) created by Tirupati_Singh
- Status changed to Needs review
12 months ago 7:50am 28 December 2023 - 🇮🇳India Tirupati_Singh
I've upgraded the module to Drupal 10. Please review.
- 🇺🇸United States mustafasayilan
Thanks a lot for your helps. Merged with your patch (I am new here sorry if i have some mistakes)
- 🇮🇳India Tirupati_Singh
Hi @mustafasayilan, you can change the issue status to Fixed if no error encountered after merging MR and grant credit to the contributors for the fixes. You take reference from the drupal docs Granting credit to issue contributors → . Hope it'll help you.
- Status changed to Fixed
10 months ago 7:53pm 21 February 2024 - 🇮🇳India Tirupati_Singh
Hi @mustafasayilan, could you grant me credit for the MR !1 for the issue fixes.
- 🇺🇸United States mustafasayilan
@tirupati_singh You have an access now. Thanks!
- 🇮🇳India Tirupati_Singh
@mustafasayilan, I already have the access to the repository. I'm talking about the Credit for the Merge Request 1 that have Merged for the issue fixes.
Automatically closed - issue fixed for 2 weeks with no activity.