When loading a form with a lot of fields, the hook `gin_preprocess_form_element` is called for each element. For each call to this hook, the GinDescriptionToggle class calls the GinSettings get method which leads to a DB lookup of the user_data table. While this query isn't expensive, we shouldn't need to repeat it for each field in the form.
Profile some pages with gin forms
We could use a static cache in Gin Settings to reuse values already fetched
This code could be improved upon, it seems the new way loads all the settings from one DB call, potentially we could statically cache all those values at once. I didn't fully grok the fallback legacy stuff, so I played it safe with the way the first patch works.
Needs review
Code
It affects performance. It is often combined with the Needs profiling tag.
Great, can you create a MR for this? We don't use patches anymore. Thank you in advance!
I have fixed a notice that showed up so this is working now as expected.