Optimize UserAuthenticationController by remove duplicate entity queries

Cloned the issue which cloned the status, not RTBC...

Ahmad Aziz → made their first commit to this issue’s fork.

Fixing the title - there is no UserLoginController :)

Would it be scope creep to add a test to show this update in 📌 Optimize user logins by avoiding duplicate entity queries Needs work we could see the query count go down.

@smustgrave I don't think so. See https://www.drupal.org/project/drupal/issues/3425342#comment-15473186 📌 Optimize \Drupal\basic_auth\Authentication\Provider\BasicAuth::authenticate() Needs review for a similar decision. We are just moving to a new API added by another issue. If we start requiring test coverage for this we'll never get anything done.

We could open a new issue to add performance tests of this controller (although if we're going to start testing REST/JSON:API endpoints, not sure that's the first one I'd add, but maybe?), but yeah it shouldn't block this issue in itself.

Thanks for answering, opened 📌 Explore performance testing for REST/JSON:API endpoints Active in case

Looks great. Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Reverted based on discussion in 📌 Optimize user logins by avoiding duplicate entity queries Needs work .

Postponing on 📌 Optimize user logins by avoiding duplicate entity queries Needs work , this probably will have to be tackled as part of that issue with the new approach, so can be marked duplicate if that happens.

This was done in 📌 Optimize user logins by avoiding duplicate entity queries Needs work