Use Gitlab CI template and minor code styling fixes

Issue created by @simonbaese
Merge request !52Resolve #3410627: Use Gitlab CI template and minor code styling fixes → (Merged) created by simonbaese
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Status changed to Needs work about 1 year ago10:14pm 22 December 2023
Comment about 1 year ago →
🇩🇪Germany simonbaese Berlin
Open tasks:

Add composer dependency for better_exposed_filters to have passing PHPStan analysis.

Fix linting in style sheets.

Fix linting in JavaScript files.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Issue was unassigned.
Status changed to Needs review about 1 year ago11:06pm 22 December 2023
Comment about 1 year ago →
🇩🇪Germany simonbaese Berlin
@gxleano There are two tasks open.

Fix linting in JavaScript files (ESLint).

Remove Drupal CI configuration from project. PHPUnit jobs can be done with Gitlab CI.

Fixing the ESLint should maybe be addressed in a separate issue, because there are many errors and this merge request may become too convoluted.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
2 pass
Comment about 1 year ago →
🇪🇸Spain gxleano Cáceres
Thanks @simonbaese

https://www.drupal.org/project/tagify/issues/3410627#comment-15372397 📌 Use Gitlab CI template and minor code styling fixes Needs review - Yes, let's create a new issue to handle the ES linting errors.

On the other hand, I will check the changes added here.
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 12 months ago
2 pass
Comment 12 months ago →
System Message

gxleano → committed 75e772ed on 1.2.x authored by simonbaese →
Resolve #3410627: Use Gitlab CI template and minor code styling fixes
Status changed to Fixed 12 months ago7:31pm 17 January 2024
Comment 12 months ago →
🇪🇸Spain gxleano Cáceres
Status changed to Fixed 12 months ago12:03pm 20 January 2024
Comment 12 months ago →
🇪🇸Spain gxleano Cáceres

Use Gitlab CI template and minor code styling fixes

Problem/Motivation

Proposed resolution

Remaining tasks

Merge Requests

!52Use Gitlab CI template and minor code styling fixes
Merged

Comments & Activities

Use Gitlab CI template and minor code styling fixes

Problem/Motivation

Proposed resolution

Remaining tasks

Merge Requests

!52Use Gitlab CI template and minor code styling fixesMerged

Comments & Activities

!52Use Gitlab CI template and minor code styling fixes
Merged