- Issue created by @juancarielo
- Status changed to Needs review
6 months ago 1:19am 27 December 2023 - First commit to issue fork.
- First commit to issue fork.
I've made a merge request here to add a 'None' option for the Page Assist setting because there are cases where Monsido is being used but Page Assist should not be enabled. If the 'None' radio button is selected, neither of the page assist scripts will be added. Here is the MR: https://git.drupalcode.org/issue/monsido_tools-3410564/-/merge_requests/...
- Issue was unassigned.
- 🇨🇦Canada mandclu
These changes look great. The only thing I'm not sure about is the requirement for jQuery in the JS libraries. I don't see anything in the local code that makes it seem necessary. Did I miss something? Or maybe it's needed for one or both of Monsido's scripts?
-
mandclu →
committed 1d97cdf7 on 1.0.x authored by
juancarielo →
Issue #3410564 by mandclu, flitt1, juancarielo: Module improvements to...
-
mandclu →
committed 1d97cdf7 on 1.0.x authored by
juancarielo →
- 🇨🇦Canada mandclu
Thanks for everyone's work on this. This has been merged in, and will be incorporated into a new release shortly.
- Status changed to Fixed
3 months ago 4:37pm 1 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.