Video overlay should not nudge people to accept all cookies

Created on 21 December 2023, 6 months ago
Updated 15 March 2024, 3 months ago

Using cookies_filter to filter external video providers (YouTube + Vimeo) shows an "allow all" button - which will set cookies to all. Instead it should only "allow" the cookies service filter in use.
Is this already possible to be set? Otherwise I would count this as a feature request.

📌 Task
Status

RTBC

Version

1.2

Component

Submodule: cookies_filter

Created by

🇩🇪Germany vistree

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @vistree
  • 🇩🇪Germany vistree

    Can one of the maintainers please explain, if the "Alle zulassen" / "Accept All" is really what we want to display as button overlay to filtered content?
    What do others think? Should we "accept all" cookies with this button or should we only accept the video related cookie settings?

  • 🇩🇪Germany Anybody Porta Westfalica

    @vistree could you please add a marked screenshot for clarification? Thanks :)

  • 🇩🇪Germany vistree

    @Anybody - sure: on the attached screenshot you find the standard video filter overlay (cookies-filter-overlay-button.png). The button "Accept all Cookies" will trigger all cookis from all "groups".
    So, it is the same behaviour as in the main cookies dialog (cookies-main-dialog.png)
    From my point of view it should instead only set the cookie for the "video" group (cookie-video-dialog.png)

  • 🇩🇪Germany Anybody Porta Westfalica

    Thanks, I think I got your point!

    At you suggest showing the smaller text below as larger button and the button as smaller text?

    So that you're not being "nudged" to accept all cookies, right?

    Regarding the other screenshots I think all is fine, as "Save" is the primary action and all others are equally weighted?

    Regarding privacy, I agree we can do that and should of course allow site owners to override this by CSS.

    Did I get you right?

    If yes, please prepare a MR for that.

  • 🇩🇪Germany vistree

    To be honest ... I even did not realize, that the smaller text is there and can do what I was missing ;-)
    So, yes. You are right ;-) We should make the "Video only" accept link a button and make the "Accept all cookies" less prominent - or we can also remove it??
    What do you think?
    I can then try to create a MR ;-)

  • 🇩🇪Germany Anybody Porta Westfalica

    Thanks, I'd think we should switch them. Happy to review your MR! :)

  • Pipeline finished with Failed
    4 months ago
    Total: 366s
    #118313
  • 🇩🇪Germany vistree

    @Anybody: can you have look at the MR? Errors seem not to be related to my changes …

  • Assigned to Grevil
  • Status changed to Needs review 4 months ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Thanks yes, I'll ask @Grevil to check this, when he reviews the other issues!

  • 🇩🇪Germany Grevil

    Not related to your MR!
    Tests are currently failing on the main branch (probably due to a recent hotfix). On it.

  • Issue was unassigned.
  • 🇩🇪Germany Grevil

    Tests are green again on dev! A quick rebase on current 1.2.x should do the trick.

  • Pipeline finished with Success
    4 months ago
    Total: 442s
    #119016
  • 🇩🇪Germany vistree

    Thanx @Grevil and @Anybody,
    my MR now was build successfully.

  • 🇩🇪Germany Grevil

    Alright, I also removed the full stops, since they look quite weird on the big button:

    Otherwise, this should be good to go as long as the tests suceed! :)

  • Status changed to RTBC 3 months ago
  • 🇩🇪Germany Grevil

    All green! Let's merge this!

  • 🇩🇪Germany vistree

    Thank you Grevil ;-)

Production build 0.69.0 2024