- Issue created by @kbrodej
- Merge request !45Issue #3410208 by kbrodej: Using a translatable string as a category for field type is deprecated in drupal:10.2.0 → (Open) created by kbrodej
- last update
about 1 year ago 61 pass - Status changed to Needs review
about 1 year ago 10:19am 21 December 2023 - Status changed to Needs work
about 1 year ago 10:28am 21 December 2023 - 🇨ðŸ‡Switzerland berdir Switzerland
This can only be done when the project requires 10.2, otherwise it breaks functionality on lower versions.
And it's not just about removing the translate class, categories are machine names now, so it will need to be decided where this fits in the new category system.
- 🇮🇳India himanshu_jhaloya Indore
Hi,
To maintain compatibility, where categories are represented by machine names, you can define a custom category and use its machine name. - Status changed to Needs review
10 months ago 3:16pm 15 February 2024 - last update
10 months ago 61 pass - Status changed to Needs work
10 months ago 9:43am 16 February 2024 - 🇩🇰Denmark ressa Copenhagen
Thanks @himanshu_jhaloya. Manually attaching patches is being phased out, and you should create a patch and Merge Request with the Gitlab integration.
DrupalCI and all patch testing will be turned off on July 1, 2024 →
- Status changed to Postponed
10 months ago 10:57am 25 February 2024 - 🇬🇧United Kingdom adamps
Postponed until June 2024 when support for D10.1 ends - see #4
- Status changed to Needs work
10 months ago 7:26pm 26 February 2024 - 🇨ðŸ‡Switzerland berdir Switzerland
That's tricky because EOL for 10.1 might also be when 11.0 gets released (yep, that soon already).
This is what we did in entity_reference_revisions:
/** * Implements hook_field_info_alter(). */ function entity_reference_revisions_field_info_alter(&$info) { if (version_compare(\Drupal::VERSION, '10.1.999', '<')) { $info['entity_reference_revisions']['category'] = t('Reference revisions'); } }
So put the new category into the annotation and then switch back in the info hook.
But looking again at the change, this is even easier. this is no_ui field type, the category was just copy pasted but is useless here as it is, per no_ui = TRUE, never actually shown in the UI.
So, just remove the category, problem solved.
- Status changed to Needs review
10 months ago 11:23am 27 February 2024 - last update
10 months ago 61 pass - 🇬🇧United Kingdom adamps
Please can someone review/confirm that this fixes the problem?
> Manually attaching patches is being phased out, so perhaps you can create a patch and Merge Request with the Gitlab integration.
Yes but it's not currently working unfortunately see 📌 Use gitlab-ci Needs work
- Status changed to RTBC
10 months ago 7:30pm 28 February 2024 - 🇨ðŸ‡Switzerland berdir Switzerland
Should be OK IMHO. Didn't test, but there's really not much that you can test as it doesn't show up anywhere ;)
- 🇩🇰Denmark ressa Copenhagen
> Manually attaching patches is being phased out, so perhaps you can create a patch and Merge Request with the Gitlab integration.
Yes but it's not currently working unfortunately see 📌 Use gitlab-ci Needs work
Ah yes ... it's a race against time now, since DrupalCI and all patch testing will be turned off on July 1, 2024 → .
If it isn't created already, someone should create a meta "support group" issue for module maintainers struggling with the transition to Gitlab CI tests :)
- 🇨ðŸ‡Switzerland berdir Switzerland
There's the #gitlab channel on Slack for asking questions, but this might be a bit too advanced for that.
FWIW, this doesn't prevent creating merge requests, they still run DrupalCI tests as well.
-
AdamPS →
committed b3b6ba19 on 4.x
Issue #3410208 by AdamPS, himanshu_jhaloya, Berdir: Using a translatable...
-
AdamPS →
committed b3b6ba19 on 4.x
- Status changed to Fixed
10 months ago 12:46pm 5 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.