- Issue created by @sime
- 🇦🇺Australia sime Melbourne
Just leaving a note here that this custom code is throwing phpstan errors and I notice there are quite a lot in entity_diff_ui.
------ ---------------------------------------------------------------------------------------------- Line contrib/entity_diff_ui/src/Form/RevisionOverviewForm.php ------ ---------------------------------------------------------------------------------------------- 208 Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface: in drupal:10.1.0 and is removed from drupal:11.0.0. Use \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead. 211 Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface: in drupal:10.1.0 and is removed from drupal:11.0.0. Use \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead. - Status changed to Needs review
8 months ago 11:10pm 12 February 2024 - 🇦🇺Australia sime Melbourne
The attached code is working really well for us, and I would like to see this added to the entity_diff_ui as a submodule.
- 🇦🇺Australia mingsong 🇦🇺
Thanks @Si,
Yes, please create a MR, we can go from there.
- Status changed to Needs work
8 months ago 11:06pm 13 February 2024 - Status changed to Closed: won't fix
6 months ago 5:39am 28 March 2024 - 🇦🇺Australia sime Melbourne
As discussed at DrupalSouth we'll keep the code custom since there is a generic revision UI on the way. The zip file is still here for anyone to use.