META 3.0.0

smustgrave → credited jurgenhaas → .

For the testing via slack.

Ready for 1 last round of reviews.

I noticed there is a ton of dependencies being injected into the base plugin. Are all these needed for the large majority of plugins? Otherwise, it may be better to keep the injected dependencies to a minimum and have individual plugins pull their dependencies from the container in the create() method.

Another observation: some of the checks build batches themselves, which rely on some postively old looking include files. Might it be an idea to implement batching in the run() method of the plugins somehow? I found the field scan could benefit from some batching, because I was running into trouble with it trying to scan the field value for over 300 000 private messages. This may be too big of a change in the RC stage, though.

Any improvements you see feel free to open tickets up. Can't say they'll get in before 3.0.0 release as aiming for functional first but definitely in following releases for sure.

Comment #20 I think should be done before a 3.0.0 release though.

I think the groundwork for #21 as well. It would be a good idea to prepare the SecurityCheckInterface to be able to call run() repeatedly and pass some of the batch information back and forth (I think finished info and a/the sandbox). We should also port at least one of the batch checks as a proof of concept. The others could follow in minor releases, probably. It would make the checks fully self-contained.

Excellent that we got these in!

Just did a rc4 release.

Will give it a few weeks before tagging a 3.0.0 release.

📌 Batchify and optimize field scan (dangerous tags in content) Needs review is the last ticket but don't think it's a hard blocker.

Still todo for myself update the module page with new checks.

Agreed that 📌 Batchify and optimize field scan (dangerous tags in content) Needs review can wait until a subsequent release.

Agreed but lets see if we can get 📌 Scan freezes on File permissions. Guzzle Error Needs review in for 3.0.0 as the last one

Just did a 3.0.0, thanks everyone for helping get there!

Great work, smustgrave! I appreciate all your effort to improve this module and modernize it.

Excellent.

Automatically closed - issue fixed for 2 weeks with no activity.