Updated icon for X/Twitter

Hi, created the patch for the issue. Please review

The last submitted patch, 3: 3408538.patch, failed testing. View results →

Hi, the pr https://github.com/AdamPS/rrssb-plus/pull/14 has been created for rrssb-plus to add icon for X. Once its merged and rrsb-plus is updated, the patch should work fine. Please review again after pr is merged.

@samir we have updated the svg icon in rrssb-plus git repo and it is merged by @adam at https://github.com/AdamPS/rrssb-plus/pull/14.
Please check the changes now.

Hi, the pr is merged of that icon on rrssb-plus library, but when installed via composer the icon is not visible in that library. This is the screenshot when we manually added the X svg related files.

patch needs work: I have tested the patch on version 8.x-2.5 and the results are not as expected, i've configured the new 'X' option in the module settings form but when i go to check out the icons at the frontend there is no X icon.

Yes if we just change the array key from twitter to x then it will break existing sites. It would need an update hook.

Or maybe some sites will want X and some Twitter? We could keep both options??

I believe it would be better to allow both options—support for Twitter and X. This way, site maintainers can choose to use either platform or both, depending on their needs. It would also allow for a smoother transition, letting those who still refer to Twitter gradually shift to X.

Here is a patch that adds settings for X and is compatible with the dev version of AdamPS/rrssb-plus, which includes the X icons

Thanks. Drupal.org no longer supports patches, only merge requests please.

Thanks. The tests are failing because I need to create a release for RRSSB library.

I created the RRSSB library release. I tried to rerun the tests, but it still picked up the old version. Maybe I need to wait longer, or somehow clear a cached download?

I've rescheduled the build, and Composer has now picked up the new library version. I also rescheduled the PHPUnit tests, and it looks like they passed successfully.

Great thanks everyone, now fixed