Fix PHPStan warnings

------ ---------------------------------------------------------------------- Line src/ReCaptcha/RequestMethod/Drupal8Post.php ------ ---------------------------------------------------------------------- 35 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line tests/src/Kernel/ValidateD7MigrationStateTest.php ------ ---------------------------------------------------------------------- 24 Property Drupal\Tests\recaptcha\Kernel\ValidateD7MigrationStateTest::$modules property must be protected. 💡 Change record: https://www.drupal.org/node/2909426 ------ ----------------------------------------------------------------------

Return type mixed of method Drupal\Tests\recaptcha\Functional\RecaptchaJavascriptTest::setUp() is not covariant with return type void of method Drupal\Tests\BrowserTestBase::setUp(). in tests/src/Functional/RecaptchaJavascriptTest.php:38

Comments & Activities

Issue created by @Anybody
Comment 10 months ago →
🇩🇪Germany Anybody Porta Westfalica
Comment 10 months ago →
🇮🇳India deepak.cms
deepak.cms → made their first commit to this issue’s fork.
Merge request !30Fixed PHPStan errors. → (Merged) created by deepak.cms
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
4 pass
Comment 10 months ago →
🇮🇳India deepak.cms
Hi @Anybody,

Fixed the PHPStan warnings. Please review.

Thanks
Status changed to Needs work 10 months ago10:25am 16 December 2023
Comment 10 months ago →
🇩🇪Germany Anybody Porta Westfalica
Thanks, still something left: https://git.drupalcode.org/issue/recaptcha-3408409/-/jobs/491924
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
4 pass
Comment 9 months ago →
🇮🇳India deepak.cms
Hi @Anybody,

Fixed the remaining issue.

Thanks
Status changed to Needs review 9 months ago12:34pm 18 December 2023
Comment 9 months ago →
🇩🇪Germany Anybody Porta Westfalica
Thanks, LGTM - let's have some people testing it. Furthermore, I think we need an empty post update hook to clear the caches for a new service?
Status changed to RTBC 9 months ago8:06am 22 December 2023
Comment 9 months ago →
🇩🇪Germany Anybody Porta Westfalica
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
4 pass
Comment 9 months ago →
System Message

Anybody → committed 7c00cf69 on 8.x-3.x authored by deepak.cms →
Issue #3408409 by deepak.cms, Anybody: Fix PHPStan warnings
Status changed to Fixed 9 months ago8:07am 22 December 2023
Comment 9 months ago →
🇩🇪Germany Anybody Porta Westfalica
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!30Fix PHPStan warnings
Merged

Comments & Activities

Fix PHPStan warnings

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!30Fix PHPStan warningsMerged

Comments & Activities

!30Fix PHPStan warnings
Merged