Fix ESLINT errors

/builds/project/cloudflare_stream/web/modules/custom/cloudflare_stream/js/cloudflare_stream.js 1:2 warning Unexpected unnamed function func-names 3:5 warning Unexpected unnamed method 'attach' func-names 3:5 error Expected method shorthand object-shorthand 3:23 warning 'context' is defined but never used no-unused-vars 3:32 warning 'settings' is defined but never used no-unused-vars 4:11 error 'uniqueStreamIDs' is never reassigned. Use 'const' instead prefer-const 7:31 warning Unexpected unnamed function func-names 7:46 error 'settings' is already declared in the upper scope on line 3 column 32 no-shadow 8:13 error 'stream' is never reassigned. Use 'const' instead prefer-const 8:24 error Unexpected string concatenation prefer-template 9:15 error Use object destructuring prefer-destructuring 10:15 error Use object destructuring prefer-destructuring 11:15 error Use object destructuring prefer-destructuring 12:15 error Use object destructuring prefer-destructuring 13:15 error Use object destructuring prefer-destructuring 14:15 error Use object destructuring prefer-destructuring 17:22 error Replace `'preload':""` with `·preload:·''·` prettier/prettier 20:25 error Replace `.removeClass('vjs-controls-disabled')` with `⏎············.removeClass('vjs-controls-disabled')⏎············` prettier/prettier 29:23 error Replace `"loop"` with `'loop'` prettier/prettier 34:6 error Insert `,` prettier/prettier ✖ 20 problems (15 errors, 5 warnings) 14 errors and 0 warnings potentially fixable with the `--fix` option.

Comments & Activities

Issue created by @tim-diels
First commit to issue fork.
Merge request !23Fixed some errors and warrnings reported by eslint → (Merged) created by thakurnishant_06
Status changed to Needs review over 1 year ago12:33pm 19 December 2023
Comment over 1 year ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪
Thanks for the work. I fixed the last 2 warnings and reverted a small change that is not needed here.
Status changed to RTBC over 1 year ago12:51pm 19 December 2023
Comment over 1 year ago →
thakurnishant_06 India
Hello @tim-diels,

Thanks for the swift review. All errors and warnings flagged by ESLint have been resolved. The last pipeline run was clean with no reported errors.
Moving to RTBC.

Thank you.
Comment over 1 year ago →
System Message

tim-diels → committed e7d40793 on 3.0.x authored by thakurnishant_06 →
Issue #3408300 by thakurnishant_06, tim-diels: Fix ESLINT errors
Status changed to Fixed over 1 year ago1:20pm 19 December 2023
Comment over 1 year ago →
🇧🇪Belgium tim-diels Belgium 🇧🇪
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!23Fix ESLINT errors
Merged

Comments & Activities

Fix ESLINT errors

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!23Fix ESLINT errorsMerged

Comments & Activities

!23Fix ESLINT errors
Merged