Created on 12 December 2023, 7 months ago
Updated 13 February 2024, 4 months ago

Problem/Motivation
GitlabCi has been released to all projects and will eventually replace DrupalCi.
GitlabCi offers more advanced features including code coverage reporting which can help improve releases going forward.

Proposed resolution
Create and test a GitlabCi file (.gitlab-ci.yml file) and make integration.

๐Ÿ“Œ Task
Status

Fixed

Version

4.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia deepakkm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @deepakkm
  • Status changed to Needs work 7 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly itamair

    thanks @ https://www.drupal.org/u/deepakkm โ†’
    BUT ...
    please add more content info / descriptions once you open new Issues.
    Everybody time is important ... (also to understand what it is the more detailed issue context)

  • ๐Ÿ‡ฎ๐Ÿ‡นItaly itamair
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Prashant.c Dharamshala

    Prashant.c โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Prashant.c Dharamshala

    Incorporated a .gitlab-ci.yml file into the project's root directory by utilizing the Drupal Association's template.gitlab-ci.yml contents. Continuously learning about it as I progress.

    Thanks

  • Merge request !41Basic template for gitlab CI โ†’ (Open) created by itamair
  • First commit to issue fork.
  • Merge request !44Feature: Gitlab CI definition. โ†’ (Merged) created by progga
  • Pipeline finished with Success
    5 months ago
    #82408
  • Pipeline finished with Running
    5 months ago
    #82470
  • Pipeline finished with Success
    5 months ago
    #82732
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom progga

    Hello,
    I have raised a new pull request for this task. It is getting a green although PHPStan checks have returned some errors.

    Change summary:
    - Drupal Association Gitlab CI template.
    - Coding standard fixes for PHP, Javascript, and CSS code.
    - I have added some development dependencies to composer.json to make PHPStan happier. Without this change, PHPStan flags up even more errors.

    I have avoided making any code changes suggested by PHPStan to avert potential side effects. Perhaps these remaining issues can be dealt with in a separate ticket. Remaining issues include:
    - "Unsafe usage of new static()". These could be easily resolved by declaring relevant class constructors as "final". I can't say if such a change will have any side effect.
    - "\Drupal calls should be avoided in classes, use dependency injection instead".
    - Use of two unknown classes: `Geometry`, and `GeometryCollection`.

  • Status changed to Fixed 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly itamair

    Ok ... good job. I added some commits to fix (or ignore) all Phpstan errors/issues.
    Gitlab CI going to be deployed along new Geocoder release (both 4.x and 3.x branch).

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom progga

    Thanks a lot. That was real quick :)

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024