- Issue created by @deepakkm
- Status changed to Needs work
about 1 year ago 8:25am 12 December 2023 - ๐ฎ๐นItaly itamair
thanks @ https://www.drupal.org/u/deepakkm โ
BUT ...
please add more content info / descriptions once you open new Issues.
Everybody time is important ... (also to understand what it is the more detailed issue context) - ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia prashant.c Dharamshala
Incorporated a .gitlab-ci.yml file into the project's root directory by utilizing the Drupal Association's template.gitlab-ci.yml contents. Continuously learning about it as I progress.
Thanks
- First commit to issue fork.
- Status changed to Needs review
12 months ago 3:19pm 26 January 2024 - ๐ฌ๐งUnited Kingdom progga
Hello,
I have raised a new pull request for this task. It is getting a green although PHPStan checks have returned some errors.Change summary:
- Drupal Association Gitlab CI template.
- Coding standard fixes for PHP, Javascript, and CSS code.
- I have added some development dependencies to composer.json to make PHPStan happier. Without this change, PHPStan flags up even more errors.I have avoided making any code changes suggested by PHPStan to avert potential side effects. Perhaps these remaining issues can be dealt with in a separate ticket. Remaining issues include:
- "Unsafe usage of new static()". These could be easily resolved by declaring relevant class constructors as "final". I can't say if such a change will have any side effect.
- "\Drupal calls should be avoided in classes, use dependency injection instead".
- Use of two unknown classes: `Geometry`, and `GeometryCollection`. - Status changed to Fixed
12 months ago 10:43pm 28 January 2024 - ๐ฎ๐นItaly itamair
Ok ... good job. I added some commits to fix (or ignore) all Phpstan errors/issues.
Gitlab CI going to be deployed along new Geocoder release (both 4.x and 3.x branch). Automatically closed - issue fixed for 2 weeks with no activity.