- Issue created by @mondrake
- Status changed to Needs review
6 months ago 6:37pm 11 December 2023 - Status changed to RTBC
6 months ago 4:28pm 15 December 2023 - 🇺🇸United States smustgrave
Seems moving the assertions to their own function still covers the original. Tests are green and no coverage appears to have been lost. LGTM.
- Status changed to Needs review
5 months ago 8:13am 29 December 2023 - 🇳🇿New Zealand quietone New Zealand
I read the comments and carefully went through the MR. This does look like a nice bit of cleanup and helps with readability. I just have a question about the removal of
$this->cleanUp();in two instances.Setting to Needs review for an answer.
- Status changed to RTBC
5 months ago 9:22am 29 December 2023 -
quietone →
committed 5cce3470 on 11.x
Issue #3407979 by mondrake, smustgrave: Cleanup...
-
quietone →
committed 5cce3470 on 11.x
- Status changed to Fixed
5 months ago 7:43am 31 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.