- Issue created by @DamienMcKenna
- πΊπΈUnited States jrockowitz Brooklyn, NY
The \Drupal\schemadotorg\Element\SchemaDotOrgSettings element supports adding a token link.
This should be as easy as adding
#token_link' => TRUE
to each element that needs it. - πΊπΈUnited States jrockowitz Brooklyn, NY
BTW, where is the "Browse available tokens." link missing?
- Status changed to Needs review
7 months ago 3:07pm 11 December 2023 - πΊπΈUnited States DamienMcKenna NH, USA
The JSON-LD Custom Settings fields on the JSON-LD settings form was the main place I missed them - the links are visible on the other places the "JSON-LD Custom" field shows up, e.g. on "Manage fields" pages.
- πΊπΈUnited States DamienMcKenna NH, USA
The complicated part with the token browser on these forms is that the strings are processed after they're added to other entity forms, so it could process tokens for multiple entity types.
- πΊπΈUnited States jrockowitz Brooklyn, NY
@DamienMcKenna, I think you uploaded the wrong patch.
I do not completely understand the comment in #5. Do we need to adjust the supported tokens?
- πΊπΈUnited States DamienMcKenna NH, USA
I did, I didn't wait for finder to show the new file before clicking "Save" X-)
How about this one?
#5 rewritten: The token browser for global settings has to accommodate all entity types, as those settings fields can be applied to any page on the site.
- πΊπΈUnited States jrockowitz Brooklyn, NY
The MR includes the patch and tweaks so that token types automatically support all entity types that are supported via Schema.org.
- Merge request !92Issue #3407946 by DamienMcKenna: Add link to token browser on fields that will... β (Merged) created by jrockowitz
- πΊπΈUnited States jrockowitz Brooklyn, NY
I think we can merge this AS-IS and gradually tweak the #token_types as needed.
- πΊπΈUnited States DamienMcKenna NH, USA
So that looks like a good improvement, nice!
With the merge request the browser doesn't show the tokens for taxonomy terms but does for users, even though both entity types have mappings defined. Might something else on the site be interfering?
- πΊπΈUnited States jrockowitz Brooklyn, NY
Good catch. We need to convert 'taxonomy_term' to 'term' for
#token_types
. - Status changed to RTBC
7 months ago 8:21pm 11 December 2023 -
jrockowitz β
committed 67e56979 on 1.0.x
Issue #3407946 by DamienMcKenna: Add link to token browser on fields...
-
jrockowitz β
committed 67e56979 on 1.0.x
- Status changed to Fixed
7 months ago 8:44pm 11 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.