- Issue created by @bradjones1
- Status changed to Needs review
9 months ago 5:46pm 8 December 2023 - πΊπΈUnited States bradjones1 Digital Nomad Life
The test-only CI run skips because it's configured for MySQL...but the only "actual" test class changed here is pgsql. Raised a question in Slack. Don't think that should necessarily hold this up, however.
- πΊπΈUnited States bradjones1 Digital Nomad Life
Test-only changes here aren't going to be helpful because we're adding test coverage, not demonstrating a bug... π
I think this should be ready for review. Some initial test failures but they look to be unrelated/related to new performance testing.
- Status changed to RTBC
9 months ago 4:30pm 11 December 2023 - πΊπΈUnited States smustgrave
Additional test coverage is always a plus.
See you ran tests for all the different database types and no failures.
The comments read fine to me.
- Status changed to Needs work
8 months ago 12:24am 29 December 2023 - π³πΏNew Zealand quietone New Zealand
I'm triaging RTBC issues β .
I agree with @smustgrave that additional test coverage is always welcome.
I read the IS, the comments and the MR. I didn't see any unanswered questions. I then tried to apply the diff but it no longer applies.
While reading the MR I was having trouble with the different terms applied to this type of index being tested. It seems that functional, alternative and prefix are being used for the same thing. While I could be wrong it does suggest that consisting in the wording and the method names would help. I also think adding a link to this 'rarely used syntax' would be beneficial.
Setting back to NW for the above.