- Issue created by @wim leers
- Merge request !5705Resolve #3406487 "Typedconfigmanagers variable value" β (Open) created by wim leers
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:10pm 6 December 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Use the term
dynamic type names
, which #2392057: Config schema fails to expand dynamic top-level types β introduced forTypedConfigManager::getDefinitionWithReplacements()
's* @param array $replacements * An array of replacements for dynamic type names.
.
Related: π [PP-1] Validate inputs of config schema's TypeResolver: only allow %parent, %type and %key Postponed .
- π§πͺBelgium borisson_ Mechelen, π§πͺ
I agree that dynamic type expression is clearer than variable value. I think this is a good improvement.
- πΊπΈUnited States phenaproxima Massachusetts
I like "dynamic type name" as a consistent term. I am, however, okay with "dynamic type expression", although I think we would definitely want to provide a clear example of what one looks like, since it's a more generic/CompSci-ish term overall.
So:
- "Dynamic type name" is my first choice.
- "Dynamic type expression" is my second choice, as long as we are very clear, with examples, that this means "a type name which is dynamic and contains [ and ]".
- Status changed to Needs work
about 1 year ago 2:07pm 6 December 2023 - πΊπΈUnited States phenaproxima Massachusetts
Couple minor suggestions but this is light-years better than what's in HEAD. As far as I'm concerned, RTBC once my points are resolved. :)
- Status changed to Needs review
about 1 year ago 2:27pm 6 December 2023 - Status changed to RTBC
about 1 year ago 2:28pm 6 December 2023 - π¨πSwitzerland bircher π¨πΏ
I was not bothered too much about the old name, but I agree that this is an improvement.
RTBC +1
- Status changed to Needs work
about 1 year ago 5:45pm 12 December 2023 - π¬π§United Kingdom alexpott πͺπΊπ
Let's preserve BC and add replaceName/Variable back it but trigger deprecations.
- Assigned to wim leers
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 6:04pm 12 December 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
- Change record created (was also missing! π): https://www.drupal.org/node/3408266 β
- #13 addressed
Self re-RTBC'ing because this is such a trivial change.
- Status changed to Fixed
about 1 year ago 11:41pm 12 December 2023 -
alexpott β
committed 2dc7b233 on 11.x
Issue #3406487 by Wim Leers, phenaproxima: Consistently use "dynamic...
-
alexpott β
committed 2dc7b233 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.