- Issue created by @ressa
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:59pm 5 December 2023 - Assigned to vincent.hoehn
- ๐ฉ๐ชGermany dbielke1986
@ressa
Thanks for reporting and creating an MR for this.
The only thing I'm unsure about is line 42 ("icon":). I imagine the line break there came from a best practice.But @vincent.hoehn will say and evaluate that.
Thank you in any case.
- Status changed to Fixed
about 1 year ago 8:52am 6 December 2023 - ๐ฉ๐ชGermany vincent.hoehn Dresden, Germany
Hello @ressa and @dbielke1986, I have merged the MR. Many thanks for the support!
The line breaks in the โiconโ were intentionally there. The aim was to give users a better understanding of how it works and should be used. So we worked with line breaks for the icon.In addition, the project description has been changed and is now up-to-date. :)
- ๐ฉ๐ฐDenmark ressa Copenhagen
Perfect, thanks @dbielke1986 and @vincent.hoehn!
I now see the path is actually this, so the
/templates/
folder bit needs to be updated to/template/
, like this. Sorry I missed that:ckeditor5_template/template/ckeditor5_template.json.example
And great that the template example got updated. It can now be copy-pasted, and works right away. A small detail: The README uses this project (ckeditor5_template) as link, whereas the project page links to the deprecated (now in core) CKEditor 5 editor ...
-
vincent.hoehn โ
committed d34de6d3 on 1.0.x
Issue #3406360: Fix minor typo in README, use CKEditor 5?
-
vincent.hoehn โ
committed d34de6d3 on 1.0.x
-
vincent.hoehn โ
committed 40d621b6 on 1.0.x
Issue #3406360 by vincent.hoehn: Fix minor typo in README, use CKEditor...
-
vincent.hoehn โ
committed 40d621b6 on 1.0.x
- ๐ฉ๐ชGermany vincent.hoehn Dresden, Germany
Sorry, @ressa. Now ALL errors/typos should really be fixed ๐
- ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks! I have to admit that updating the link and text in
ckeditor5_template/template/ckeditor5_template.json.example
slipped me as well, so great that it got updated now. But I was hinting at the code on the project page โ , which is using the CKEditor 5 editor link. -
vincent.hoehn โ
committed 1c5d28f8 on 1.0.x
Issue #3406360 by vincent.hoehn: Fix minor typo in README, use CKEditor...
-
vincent.hoehn โ
committed 1c5d28f8 on 1.0.x
- ๐ฉ๐ชGermany vincent.hoehn Dresden, Germany
Thank you! Immediately implemented.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Status changed to Fixed
12 months ago 1:17pm 5 January 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@vincent.hoehn
During find solution for templating in readme file, i find that Maintainers are not added in readme file so i have updated and created a new MR.
I am sorry if i worked without asking to reopen this ticket. - ๐ฉ๐ชGermany vincent.hoehn Dresden, Germany
Hi @ravi kant. A part of the README looked a bit strange, so I made another change.
Thanks for adding the maintainers! Have a nice day!