Issues reported by PHPStan

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$? ------ ------------------------------------------------------------------------------ Line src/Controller/EntityIdAutocompleteController.php ------ ------------------------------------------------------------------------------ 52 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ [ERROR] Found 1 error

Comments & Activities

Issue created by @bluegeek9
Comment 7 months ago →
🇮🇳India SandeepSingh199
Some time PHPStan might warn about the Unsafe usage of new static() because the late static binding might not work as expected in some scenarios. So insted of using static use self.
Status changed to Needs review 7 months ago7:13am 6 December 2023
Comment 7 months ago →
🇮🇳India SandeepSingh199
Status changed to Needs work 7 months ago4:45pm 8 December 2023
Comment 7 months ago →
🇺🇸United States bluegeek9
The class also needs to be made final, or at least the constructor.
First commit to issue fork.
Status changed to Needs review 7 months ago7:18am 12 December 2023
Comment 7 months ago →
🇮🇳India viren18febS
Hi @bluegeek9
I have fixed the issues and added a patch, please review.
Thanks
Merge request !9Issue #3406325 by viren18febS, SandeepSingh199: Issues reported by PHPStan → (Merged) created by bluegeek9
Comment 7 months ago →
System Message

bluegeek9 → committed b6a5f6ab on 8.x-1.x authored by viren18febS →
Issue #3406325 by viren18febS, SandeepSingh199: Issues reported by...
Status changed to Fixed 7 months ago1:37am 13 December 2023
Comment 7 months ago →
🇺🇸United States bluegeek9
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!9Issues reported by PHPStan
Merged

Comments & Activities

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!9Issues reported by PHPStanMerged

Comments & Activities

!9Issues reported by PHPStan
Merged